From 24e3cbc398a0299de3c1294da7ef1735ad7f7c11 Mon Sep 17 00:00:00 2001 From: clarasaia Date: Mon, 22 Dec 2025 11:57:59 +0100 Subject: [PATCH 1/2] Remove try-except around the self._generate_series() call to handle error --- ats/dataset_generators.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ats/dataset_generators.py b/ats/dataset_generators.py index faf07f2..483a9c0 100644 --- a/ats/dataset_generators.py +++ b/ats/dataset_generators.py @@ -165,15 +165,12 @@ def generate(self, n_series=9, time_span='60D', random_applied_effects = rnd.sample(random_effects, rnd.randint(0, len(random_effects))) applied_effects = list(set(effects + random_applied_effects)) - try: - series = self._generate_series(sampling_interval=self.sampling_interval, + series = self._generate_series(sampling_interval=self.sampling_interval, sub_time_span=sub_time_span, anomalies=anomalies_for_group, effects=applied_effects, max_anomalies_per_series=max_anomalies_per_series) - except Exception as e: - logger.error(f"Error generating series {i+1}: {e}") - continue + logger.info(f"Generated dataset {len(dataset)+1} with effects: {applied_effects} and anomalies: {anomalies_for_group} ") dataset.append(series) From 1d1a06ca3a75608080ce5849ea506c5d2f3d9149 Mon Sep 17 00:00:00 2001 From: clarasaia Date: Mon, 22 Dec 2025 11:58:16 +0100 Subject: [PATCH 2/2] Fix test according to previous commit --- ats/tests/test_dataset_generators.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/ats/tests/test_dataset_generators.py b/ats/tests/test_dataset_generators.py index 1915605..d1f1ca7 100644 --- a/ats/tests/test_dataset_generators.py +++ b/ats/tests/test_dataset_generators.py @@ -50,6 +50,20 @@ def test_generate_errors(self): with self.assertRaises(ValueError): generator.generate(effects=[],anomalies=['clouds']) generator.generate(effects=['clouds'],anomalies=['clouds','spike_mv']) # Should not raise + with self.assertRaises(ValueError): + generator.generate(effects=['noise'],anomalies=['AAAAAA']) + + def test_step_anomaly_error(self): + generator = HumiTempDatasetGenerator() + with self.assertRaises(NotImplementedError): + generator.generate( + n_series=5, + time_span='10D', + effects=['noise'], + anomalies=['step_uv'], + auto_repeat_anomalies=False, + anomalies_ratio=1.0 + ) #def test_generate_random_effects(self): # generator = HumiTempDatasetGenerator()