Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Overrides cannot find parts of workshop_activity #2015

Open
Tracked by #2014
esmeetewinkel opened this issue Aug 10, 2023 · 3 comments
Open
Tracked by #2014

Warning: Overrides cannot find parts of workshop_activity #2015

esmeetewinkel opened this issue Aug 10, 2023 · 3 comments
Assignees

Comments

@esmeetewinkel
Copy link
Collaborator

esmeetewinkel commented Aug 10, 2023

Description
When opening instances of workshop_activity, the console contains many warnings of the type

[W] Overrides could not find [intro_text,activity_banner,content_box]; 
 Assuming set_variables {unprocessedOverrides: Array(3), rows: {…}}
image

I'm not sure if these warnings are a problem or should just be ignored. They do clutter the console a bit, making it harder to notice actual issues.

App version
v0.16.17 of plh_tz deployment, web preview of welcome_individual template in debug mode here.

Templates
See template welcome_individual which uses workshop_activity.

Debug templates
debug_nesting_warning_child_1 and debug_nesting_warning_parent_1 show a minimal example of when this issue occurs.
imageimage
image

When the display group in debug_nesting_warning_child_1 is removed, the issue disappears, as demoed in debug_nesting_warning_child_2 and debug_nesting_warning_parent_2.

@chrismclarke
Copy link
Member

Would it be possible to create a minimal debug sheet that we can use for testing what desired behaviour might look like? I'm slightly wary as I think sometimes this warning does catch genuine issues (e.g. typos when trying to override a default), but it would be good to try reduce number of false-positives when the child content purposefully omitted

@esmeetewinkel esmeetewinkel self-assigned this Aug 24, 2023
@esmeetewinkel
Copy link
Collaborator Author

Would it be possible to create a minimal debug sheet

I created debug sheets and updated the issue description accordingly.

@esmeetewinkel esmeetewinkel removed their assignment Aug 25, 2023
@chrismclarke
Copy link
Member

chrismclarke commented Aug 25, 2023

Thanks @esmeetewinkel , debug sheets working well to recreate

I started to take a very quick look although realised it will probably be easier to visit after #2040 as that contains some extra methods for adding tests to frontend code which would probably be good to also add for this case.

I assume this isn't super high priority (but nice to have for sure), so will try revisit after #2040 is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants