Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] KW radio group styling #2641

Open
esmeetewinkel opened this issue Dec 18, 2024 · 2 comments · May be fixed by #2737
Open

[BUG] KW radio group styling #2641

esmeetewinkel opened this issue Dec 18, 2024 · 2 comments · May be fixed by #2737
Assignees
@FaithDaka
Labels
bug Something isn't working
Milestone
ParentApp Kids KW...

Comments

@esmeetewinkel
Copy link
Collaborator

esmeetewinkel commented Dec 18, 2024 •
edited
Loading

Describe the bug
The buttons in the radio_group have different heights on some screen widths.

Current vs design:
image image

App version
v0.17.0

Debug Sheet(s)
comp_radio_group template

Screenshots and videos

Screenity.video.-.Dec.18.2024.1.webm

Additional context
One might consider making this a variant of the radio_button_grid instead, since that component is trying to replace the radio_group. Although this design is not a grid, so maybe that doesn't make sense...
@esmeetewinkel esmeetewinkel added the bug Something isn't working label Dec 18, 2024
@FaithDaka
Copy link
Collaborator

@jfmcquade Is the radio_group component deprecated?

@esmeetewinkel
Copy link
Collaborator Author

esmeetewinkel commented Dec 21, 2024 •
edited
Loading

Screen video of this issue on plh_kids_kw deployment (template e.g. article_feelings_check_in_7)

Looks like the issue is either down to different heights of image and checked_image or different size between text and the "checked text" (which is the text displayed in bold).

Screenity.video.-.Dec.21.2024.2.mp4

@esmeetewinkel esmeetewinkel mentioned this issue Dec 21, 2024
Merged
@FaithDaka FaithDaka linked a pull request Jan 21, 2025 that will close this issue
Open
1 task
@FaithDaka FaithDaka linked a pull request Jan 21, 2025 that will close this issue
[FEATURE] Kuwait Theme: Radio group styling #2737
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FaithDaka FaithDaka

Labels
bug Something isn't working
Projects
None yet
Milestone
ParentApp Kids KW Ongoing
Development

Successfully merging a pull request may close this issue.

[FEATURE] Kuwait Theme: Radio group styling IDEMSInternational/open-app-builder
2 participants
@FaithDaka @esmeetewinkel