Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuditEvent.entity slice is closed #220

Closed
qligier opened this issue Feb 29, 2024 · 5 comments · Fixed by #221
Closed

AuditEvent.entity slice is closed #220

qligier opened this issue Feb 29, 2024 · 5 comments · Fixed by #221

Comments

@qligier
Copy link

qligier commented Feb 29, 2024

Section Number
StructureDefinition/IHE.MHD.ProvideBundle.Audit.Recipient
StructureDefinition/IHE.MHD.ProvideBundle.Audit.Source

Issue
The slice on AuditEvent.entity is closed. It prevents adding entities (such as those described in BALP).
That slice in other AuditEvent profiles is opened.

Proposed Change
Open the slice.

Priority:

  • Low: Typo or other minor classification that an editor can manage. Requires no group discussion.
@JohnMoehrke
Copy link
Contributor

What is your use-case for adding more entity? It is closed because that is the two entities that are appropriate.

@qligier
Copy link
Author

qligier commented Feb 29, 2024

We want to add an entity for the transaction identifier (tracecontext) in the AuditEvent. It is related to IHE/ITI.BasicAudit#100

For example, in IHE.MHD.SimplifiedPublish.Audit.Recipient:

  • the slice is open;
  • there's a slice for entity:transaction, but it only supports XRequestId (this is another issue, but the open slice makes it non-blocking).

In IHE.MHD.ProvideBundle.Audit.Recipient/IHE.MHD.ProvideBundle.Audit.Source:

  • the slice is closed;
  • there's no slice for entity:transaction.

Why the difference?

@JohnMoehrke
Copy link
Contributor

Thank you.

@JohnMoehrke
Copy link
Contributor

Let me know if this pull-request meets your needs. This pull-request will need committee review, may require a CP.

@qligier
Copy link
Author

qligier commented Mar 15, 2024

Hi @JohnMoehrke! Yes, that would allow us to create another slice for our use, thanks!
Let me know if there's a need to write a CP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants