Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Issues #145

Open
6 of 9 tasks
Nyzabes opened this issue Aug 24, 2023 · 2 comments · Fixed by #150
Open
6 of 9 tasks

DB Issues #145

Nyzabes opened this issue Aug 24, 2023 · 2 comments · Fixed by #150
Labels
backend enhancement New feature or request

Comments

@Nyzabes
Copy link
Contributor

Nyzabes commented Aug 24, 2023

  • File: webUrl broken:
    URLs for older files refer to an URL for the current branch.
    Example: yarn.lock, which does not exist in the project anymore, refers to .../blob/feature/102/... if DB was constructed on branch feature/102.
    --> The webUrl leads to a 404 page.
  • use the (currently empty) commits-stakeholders connection instead of the signature attribute in commits
  • use the (currently empty) issues-commits connection instead of the mentions attribute in issues
  • use the issues-stakeholders connection instead of the author/assignee/assignees attributes in issues
  • use the commits-commits connection instead of the parents/history attributes in commits
  • add branches-commits connection instead of using the branch attribute in commits
  • add commits-builds connection instead of using the sha/ref attributes in builds
  • add builds-stakeholders connections instead of using the user/userFullName attributes in builds
  • rename collections according to edge direction (for example: stakeholders-commits instead of commits-stakeholders since in this collection, _from points to stakeholders and _to points to commits)
@Nyzabes Nyzabes self-assigned this Aug 24, 2023
@Nyzabes Nyzabes changed the title DB: File: webUrl broken DB Issues Aug 24, 2023
@Nyzabes Nyzabes added backend enhancement New feature or request labels Aug 29, 2023
Nyzabes added a commit that referenced this issue Aug 29, 2023
- instead of storing the signature of an author in the `signature` attribute of commits, a connection is used
- the frontend still uses the `signature` attribute, but it is inferred using the connection
- #145
Nyzabes added a commit that referenced this issue Aug 31, 2023
- instead of using the `mentions` attribute in issues
- #145
Nyzabes added a commit that referenced this issue Aug 31, 2023
- commits were not sorted with new localDB function, which broke the Changes/Version mode of the Code Hotspots visualization.
- #145
Nyzabes added a commit that referenced this issue Aug 31, 2023
- instead of the `sha`/`ref` attributes in the builds collection, the commits-builds connection is used.
- #145
Nyzabes added a commit that referenced this issue Sep 7, 2023
- Because the `builds` connection does not have a `sha` attribute anymore, the Histogram endpoint was broken both in the serverDB and the localDB.
- #145
Nyzabes added a commit that referenced this issue Sep 7, 2023
- instead of using the `history` and `parents` attributes, the commits-commits connection is used.
- the graphql service infers the parents directly, as does the localDB when accessing commits. This means the `parents` attribute can still be queried, even if it's not in the DB anymore.
- query times are much faster, DB export files significantly smaller
- #145
Nyzabes added a commit that referenced this issue Sep 12, 2023
- when querying commits using the seerverDB, commits that are earlier than the specified earliest date should only be discarded after the history has been calculated for all commits. Otherwise, history calculation would not work properly.
- #145
@Nyzabes Nyzabes removed their assignment Sep 12, 2023
@uberroot4
Copy link
Member

uberroot4 commented Sep 20, 2023

Is it on purpose that each collection as e.g. commits-stakeholders is read from right to left (from-entry references stakeholders, to-entry references commits). One might would assume that the reading direction left to right would also be the direction of the edge (commits->stakeholders). As it is the same for all edge collections I investigated, we should consider simply renaming them

@Nyzabes
Copy link
Contributor Author

Nyzabes commented Sep 27, 2023

@uberroot4 You're right, I added it as a Todo.

@uberroot4 uberroot4 linked a pull request Nov 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants