Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add PCB image to bom #674

Open
oliv3r opened this issue Sep 29, 2024 · 4 comments
Open

[FEATURE] Add PCB image to bom #674

oliv3r opened this issue Sep 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@oliv3r
Copy link

oliv3r commented Sep 29, 2024

I'm using the BOM feature and quite like it. Because I was a bit lazy (lack of logo for now) I used a PCB image instead of the logo and must say I quite like it.

I do think there's still the need of a logo, and I'm not a UX person to make a pretty design, but rolling the Logo and log into the design is not a bad idea?

Currently it looks like this, and I did have to manually scale the image (though afaik kibot can do this already).

image

@oliv3r oliv3r added the enhancement New feature or request label Sep 29, 2024
@set-soft
Copy link
Member

What about generating the image first and then the BoM, specifying as logo the image generated in a previous stage?

You can force the order of outputs in many ways (priority, declaration order, command line order).

In the worst case you can run KiBot once to get the image and then again to create the BoM.

@oliv3r
Copy link
Author

oliv3r commented Oct 4, 2024

I wanted two images :) so one for the logo, e.g. the kibot robot or whatever, as you currently intended.

But then I also want to include the image of the PCB, which indeed I can get from the previous step, so I have it; I just can't specify two images in the bom's, both a logo and a pcb render.

@set-soft
Copy link
Member

set-soft commented Oct 5, 2024

And here things start to go forever ...: Side by side or one on top of the other? Which one on each side? Which relative size? And why not three images, or four?

So my recommendation is to compose the image outside KiBot. Use the convert command from Image Magick (included in the docker images) to compose the image. Is somehow complex, but you'll find plenty of examples, and you'll be able to compose the image as you like, add text, borders, etc. All can be done with commands.

@oliv3r
Copy link
Author

oliv3r commented Oct 9, 2024

I agree that then we'll end up 10 images :p

But I would argue that the logo is good to have; kind of like have 'company style' (like pre-printed paper with company logos') to make things nice, but the PCB image is nice, as it helps to visually identify the project the BOM is for.

The imagemagick route is also certainly possibible but quite a bit more complex. Which I get of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants