Conversation
tanyaka
requested changes
May 21, 2025
tanyaka
left a comment
tanyaka
left a comment
There was a problem hiding this comment.
Probably, we should not change the logic pending shareds are desabled by default, but add a new logic disabling the pending shares.
printminion-co
force-pushed
the
mk/dev/disable_pending_shares_if_unused
branch
from
72894b6 to
5b71aeb
Compare
printminion-co
changed the title
printminion-co
force-pushed
the
mk/dev/disable_pending_shares_if_unused
branch
5 times, most recently
from
5df7564 to
40c6bdd
Compare
tanyaka
force-pushed
the
mk/dev/disable_pending_shares_if_unused
branch
from
40c6bdd to
5acb610
Compare
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
# menu is removed on ./occ config:system:set --value true --type boolean -- sharing.enable_share_accept # menu is shown on ./occ config:system:set --value false --type boolean -- sharing.enable_share_accept Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
tanyaka
force-pushed
the
mk/dev/disable_pending_shares_if_unused
branch
from
5acb610 to
f115df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"pending shares" menu item is removed on
./occ config:system:set --value true --type boolean -- sharing.enable_share_accept
"pending shares" menu item is shown on
./occ config:system:set --value false --type boolean -- sharing.enable_share_accept
run test via
TODO
Checklist