From 4af55a8882708d4238da45560bc120e42eb347cd Mon Sep 17 00:00:00 2001 From: "Misha M.-Kupriyanov" Date: Mon, 23 Jun 2025 15:53:28 +0200 Subject: [PATCH 1/4] IONOS: refactor(Default): remove unnecessary semicolons Should be made 1eeec05f Signed-off-by: Misha M.-Kupriyanov --- src/components/Default.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/Default.vue b/src/components/Default.vue index 8ff96ba35..1a88e4076 100644 --- a/src/components/Default.vue +++ b/src/components/Default.vue @@ -29,12 +29,12 @@ export default { computed: { mimeIcon() { - return OC.MimeType.getIconUrl(this.mime); - } + return OC.MimeType.getIconUrl(this.mime) + }, }, mounted() { - this.doneLoading(); + this.doneLoading() }, } From 0af43701645764460440d2237b35fd2a2686ef2a Mon Sep 17 00:00:00 2001 From: "Misha M.-Kupriyanov" Date: Mon, 23 Jun 2025 15:56:18 +0200 Subject: [PATCH 2/4] IONOS: refactor(Viewer): simplify folder check logic in viewer action Signed-off-by: Misha M.-Kupriyanov --- src/files_actions/viewerAction.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/files_actions/viewerAction.ts b/src/files_actions/viewerAction.ts index c8eb6fd65..b141a420a 100644 --- a/src/files_actions/viewerAction.ts +++ b/src/files_actions/viewerAction.ts @@ -79,10 +79,7 @@ export function registerViewerAction() { // Always enabled if configured so if (configModule.alwaysShowViewer) { // disable for folders - if (nodes.some(node => node.type === 'folder')) { - return false - } - return true + return !nodes.some(node => node.type === 'folder') } return nodes.every((node) => From 35019afad89342796e3e1983a6cd9989b9637cdc Mon Sep 17 00:00:00 2001 From: "Misha M.-Kupriyanov" Date: Mon, 23 Jun 2025 16:47:09 +0200 Subject: [PATCH 3/4] IONOS: refactor(Viewer): remove unnecessary semicolons Signed-off-by: Misha M.-Kupriyanov --- src/views/Viewer.vue | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/views/Viewer.vue b/src/views/Viewer.vue index 14c58f209..6ee7cb73d 100644 --- a/src/views/Viewer.vue +++ b/src/views/Viewer.vue @@ -741,11 +741,11 @@ export default defineComponent({ // and office documents/pdfs to exclude collabora files // otherwise accept all mimes filteredFiles = fileList.filter(file => { - const mime = file?.mime; - const isOfficeDocument = mime && OC.MimeTypeList.aliases[mime]?.startsWith('x-office'); - const isPdf = mime && mime === 'application/pdf'; + const mime = file?.mime + const isOfficeDocument = mime && OC.MimeTypeList.aliases[mime]?.startsWith('x-office') + const isPdf = mime && mime === 'application/pdf' - return mime && !isOfficeDocument && !isPdf; + return mime && !isOfficeDocument && !isPdf }) } else { // filter out the unwanted mimes @@ -991,7 +991,7 @@ export default defineComponent({ return false } - + // Faster to check if at least one node doesn't match the requirements return !nodes.some(node => ( From 3b92d35ceed2b236386d4d35e2774b4c04455c06 Mon Sep 17 00:00:00 2001 From: "Misha M.-Kupriyanov" Date: Mon, 23 Jun 2025 16:48:20 +0200 Subject: [PATCH 4/4] IONOS: refactor(Viewer): remove unnecessary whitespace in node validation logic Signed-off-by: Misha M.-Kupriyanov --- src/views/Viewer.vue | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/views/Viewer.vue b/src/views/Viewer.vue index 6ee7cb73d..cf254d887 100644 --- a/src/views/Viewer.vue +++ b/src/views/Viewer.vue @@ -990,9 +990,6 @@ export default defineComponent({ if (nodes.some(node => !(node.isDavRessource && node.root?.startsWith('/files')))) { return false } - - - // Faster to check if at least one node doesn't match the requirements return !nodes.some(node => ( (node.permissions & Permission.READ) === 0