Access to restricted files that were replaced is lost

[kbrueckmann]

I couldn't find information about the expected behavior of restricted files that were replaced and published in the documentation, so at the moment this seems like a bug to me (sorry if it is intended and I missed it):

What steps does it take to reproduce the issue?

• publish a dataset with a restricted file
• replace the restricted file
• publish the draft (=> new version of the dataset)

What did you expect to happen?
For users that had access to the previous version of the file to still have access to the new version of the file. Or for a button or something similar to appear in the publication process to choose whether users should still have access to the file in the new version.

So far I understood the replace function as a way to update the same file, so that access is lost/not granted anew automatically surprised me. For new files, however, I would expect exactly that.

What happens?
Users do not have access to the new version of the file. We only found out about this after some users contacted us themselves.

To whom does it occur (all users, curators, superusers)?
All users.

Which version of Dataverse are you using?
Dataverse v. 6.5, but we do not have many datasets with restricted files, so the behavior might have been there for some time.

Any related open or closed issues to this bug report?
#9697 also deals with access to replaced files, but the focus is a different one.

[pdurbin]

@kbrueckmann thanks for reporting this!

I agree that the described behavior is unexpected, where a published restricted file becomes unavailable to someone who had access when that file is replaced in a draft. I guess that means that the FileDownloader role doesn't get copied to the new file, which has its own file id. Perhaps it should be? 🤔

It would be create to see some API tests asserting the current behavior. And like @kbrueckmann we should consider a UI update to address this.