From 8aa749b52d69eff08fd8647203d992a358cff083 Mon Sep 17 00:00:00 2001 From: Miles Stoudenmire Date: Wed, 17 Jun 2020 16:51:00 -0400 Subject: [PATCH] Fix missing return statement in QNVal constructor. Fixes issue #430. --- src/qn/qn.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qn/qn.jl b/src/qn/qn.jl index c5b82711db..8a4b681b38 100644 --- a/src/qn/qn.jl +++ b/src/qn/qn.jl @@ -7,7 +7,7 @@ struct QNVal function QNVal(name,v::Int,m::Int=1) am = abs(m) if am > 1 - new(SmallString(name),mod(v,am),m) + return new(SmallString(name),mod(v,am),m) end new(SmallString(name),v,m) end @@ -25,9 +25,9 @@ isfermionic(qv::QNVal) = modulus(qv) < 0 Base.:<(qv1::QNVal,qv2::QNVal) = (name(qv1) < name(qv2)) function qn_mod(val::Int,modulus::Int) - modulus = abs(modulus) - (modulus == 0 || modulus == 1) && return val - return mod(val,modulus) + amod = abs(modulus) + amod <= 1 && return val + return mod(val,amod) end function Base.:-(qv::QNVal)