Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new event types #215

Closed
nilmerg opened this issue Jun 24, 2024 · 3 comments · Fixed by #216
Closed

Support new event types #215

nilmerg opened this issue Jun 24, 2024 · 3 comments · Fixed by #216
Assignees
Labels
enhancement New feature or improvement
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Jun 24, 2024

The type column of the event table now has a defined type which only allows certain values:

  • acknowledgement-cleared
  • acknowledgement-set
  • custom
  • downtime-end
  • downtime-removed
  • downtime-start
  • flapping-end
  • flapping-start
  • incident-age (previously internal)
  • state

Previously only the following values where used:

  • state
  • internal (now incident-age)

We need to support the new values, remove all workarounds (internal support, message matching) and show proper phrases:

Type Phrase
acknowledgement-cleared was unacknowledged
acknowledgement-set has been acknowledged
custom no phrase needed
downtime-end left a downtime period
downtime-removed prematurely left a downtime period
downtime-start entered a downtime period
flapping-end left a flapping period
flapping-start entered a flapping period
incident-age exceeded a time constraint
state depending on severity, unchanged
@nilmerg nilmerg added the enhancement New feature or improvement label Jun 24, 2024
@nilmerg nilmerg added this to the Beta milestone Jun 24, 2024
@sukhwinder33445 sukhwinder33445 self-assigned this Jun 24, 2024
@yhabteab
Copy link
Member

There are also two new event types (mute, unmute) since Icinga/icinga-notifications#200.

@nilmerg
Copy link
Member Author

nilmerg commented Jun 26, 2024

This is a very different change. A separate issue will follow.

@yhabteab
Copy link
Member

yhabteab commented Jun 26, 2024

They are not that different, at least in regard to the event table. These two events are also part of the event.type enum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants