-
Notifications
You must be signed in to change notification settings - Fork 29
Add links to tactical overview headers #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e94b736 to
24e485f
Compare
flourish86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so far.
We also discussed the hover effect for the donut label. Are you going to add that as well?
flourish86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, found it. icingaweb2/#5400
Sorry, could have written it here. 😅 |
Add an action link on the total hosts number that opens the list that the host donut chart in the tactical overview represents considering the active filters.
Add an action link on the total services number that opens the list that the service donut chart in the tactical overview represents considering the active filters.
24e485f to
6b6e15e
Compare
The blue numbers don’t fit here. The What do you suggest @flourish86? I suggest using a style similar to what the
Suggestion:
|
"Not Fitting" is a quite subjective. The current solution already was my suggestion. The idea was to make it obvious that the number is clickable and the icing-blue highlight is the most obvious we have in our ui. So it was the best compromise we came up with (underlining them would make it harder too read, besides that we don't really have that elsewhere consistently
I see suggestion has two issues in comparison with the current one 1) the element looks quite oddly spaced (esp. in hover state)to fix that I would rather suggest to align the label and the value horizontally (see mockup), since it makes better use of the space. 2) It's not obvious, that it's clickable without hovering.
|







Add links on the tactical overview chart headers that open the lists that the donut charts represents considering the active filters.
Closes #820