Skip to content

Conversation

@jrauh01
Copy link
Contributor

@jrauh01 jrauh01 commented Aug 5, 2025

Add links on the tactical overview chart headers that open the lists that the donut charts represents considering the active filters.

Closes #820

@jrauh01 jrauh01 self-assigned this Aug 5, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 5, 2025
@jrauh01 jrauh01 requested a review from lippserd August 5, 2025 08:59
@jrauh01 jrauh01 force-pushed the feature/tactical-header-links branch from e94b736 to 24e485f Compare August 6, 2025 09:55
@jrauh01 jrauh01 requested a review from flourish86 August 6, 2025 10:04
Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far.

We also discussed the hover effect for the donut label. Are you going to add that as well?

@flourish86 flourish86 self-requested a review August 6, 2025 16:04
flourish86
flourish86 previously approved these changes Aug 6, 2025
Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, found it. icingaweb2/#5400

@jrauh01
Copy link
Contributor Author

jrauh01 commented Aug 7, 2025

Haha, found it. icingaweb2/#5400

Sorry, could have written it here. 😅

Add an action link on the total hosts number that opens the list
that the host donut chart in the tactical overview represents
considering the active filters.
Add an action link on the total services number that opens the
list that the service donut chart in the tactical overview
represents considering the active filters.
@sukhwinder33445
Copy link
Contributor

Screenshot 2025-11-06 at 14 29 35

The blue numbers don’t fit here. The .action-link (ActionLink class) is used for links which trigger an action, such as opening a modal. This is just a regular link, and visually it also looks odd.

What do you suggest @flourish86?

I suggest using a style similar to what the Hostgroups list uses:

Screenshot 2025-11-06 at 14 40 21

Suggestion:

Screenshot 2025-11-06 at 14 38 29

On Hover:
Screenshot 2025-11-06 at 14 39 09

@flourish86
Copy link
Contributor

flourish86 commented Nov 10, 2025

What do you suggest @flourish86?

"Not Fitting" is a quite subjective.

The current solution already was my suggestion. The idea was to make it obvious that the number is clickable and the icing-blue highlight is the most obvious we have in our ui. So it was the best compromise we came up with (underlining them would make it harder too read, besides that we don't really have that elsewhere consistently

Suggestion:

Screenshot 2025-11-06 at 14 38 29 On Hover: Screenshot 2025-11-06 at 14 39 09

I see suggestion has two issues in comparison with the current one

1) the element looks quite oddly spaced (esp. in hover state)

to fix that I would rather suggest to align the label and the value horizontally (see mockup), since it makes better use of the space.

2) It's not obvious, that it's clickable without hovering.

  • This applies to the "Total" element in the host group list items as well, but at least it is surrounded with clickable elements, which is not the case for Tactical Overview tiles
  • It is too similar to the heading.

Frame 22

@nilmerg nilmerg added this to the 1.4.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link to header of tactical for full list of hosts/services

5 participants