From 50d7f9e298e74f10ace4a3be220727e24ab78d95 Mon Sep 17 00:00:00 2001
From: "Alexander A. Klimov" <alexander.klimov@icinga.com>
Date: Wed, 25 Sep 2024 11:45:54 +0200
Subject: [PATCH] pkg/icingaredis/: check context termination while looping
 over channel

A `for x := range c` will block as long as c blocks, ignoring `<-ctx.Done()`.
The latter has to be checked via `select` instead, together with c.
---
 pkg/icingaredis/utils.go | 66 ++++++++++++++++++++++++----------------
 1 file changed, 40 insertions(+), 26 deletions(-)

diff --git a/pkg/icingaredis/utils.go b/pkg/icingaredis/utils.go
index 22c8661f4..edeb95aff 100644
--- a/pkg/icingaredis/utils.go
+++ b/pkg/icingaredis/utils.go
@@ -28,27 +28,34 @@ func CreateEntities(ctx context.Context, factoryFunc database.EntityFactoryFunc,
 
 		for i := 0; i < concurrent; i++ {
 			g.Go(func() error {
-				for pair := range pairs {
-					var id types.Binary
-
-					if err := id.UnmarshalText([]byte(pair.Field)); err != nil {
-						return errors.Wrapf(err, "can't create ID from value %#v", pair.Field)
-					}
-
-					e := factoryFunc()
-					if err := types.UnmarshalJSON([]byte(pair.Value), e); err != nil {
-						return err
-					}
-					e.SetID(id)
-
+				for {
 					select {
-					case entities <- e:
+					case pair, ok := <-pairs:
+						if !ok {
+							return nil
+						}
+
+						var id types.Binary
+
+						if err := id.UnmarshalText([]byte(pair.Field)); err != nil {
+							return errors.Wrapf(err, "can't create ID from value %#v", pair.Field)
+						}
+
+						e := factoryFunc()
+						if err := types.UnmarshalJSON([]byte(pair.Value), e); err != nil {
+							return err
+						}
+						e.SetID(id)
+
+						select {
+						case entities <- e:
+						case <-ctx.Done():
+							return ctx.Err()
+						}
 					case <-ctx.Done():
 						return ctx.Err()
 					}
 				}
-
-				return nil
 			})
 		}
 
@@ -72,21 +79,28 @@ func SetChecksums(ctx context.Context, entities <-chan database.Entity, checksum
 
 		for i := 0; i < concurrent; i++ {
 			g.Go(func() error {
-				for entity := range entities {
-					if checksumer, ok := checksums[entity.ID().String()]; ok {
-						entity.(contracts.Checksumer).SetChecksum(checksumer.(contracts.Checksumer).Checksum())
-					} else {
-						return errors.Errorf("no checksum for %#v", entity)
-					}
-
+				for {
 					select {
-					case entitiesWithChecksum <- entity:
+					case entity, ok := <-entities:
+						if !ok {
+							return nil
+						}
+
+						if checksumer, ok := checksums[entity.ID().String()]; ok {
+							entity.(contracts.Checksumer).SetChecksum(checksumer.(contracts.Checksumer).Checksum())
+						} else {
+							return errors.Errorf("no checksum for %#v", entity)
+						}
+
+						select {
+						case entitiesWithChecksum <- entity:
+						case <-ctx.Done():
+							return ctx.Err()
+						}
 					case <-ctx.Done():
 						return ctx.Err()
 					}
 				}
-
-				return nil
 			})
 		}