Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some stylesheet problems and suggestions #2

Open
chengluyu opened this issue Apr 18, 2021 · 0 comments
Open

Some stylesheet problems and suggestions #2

chengluyu opened this issue Apr 18, 2021 · 0 comments

Comments

@chengluyu
Copy link
Collaborator

I was cleaning my GitHub notifications and I saw issue #1. So I reviewed some CSS code and found few problems.

I also have some general suggestions.

  • Use relative units. Compared to absolute unit (e.g. px), relative units (e.g. rem and em) make you design more consistent. You can also get other benefits, for example, you can easily scale up and down your components.
  • Use less flex box. I found flex being used everywhere even simple cases. In 50% cases, you can use simpler solution rather than flex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant