Skip to content

Conversation

@didimmova
Copy link
Contributor

@didimmova didimmova commented Nov 25, 2025

Closes #1995

Verify with this Handoff

rkaraivanov
rkaraivanov previously approved these changes Nov 25, 2025
@adrianptrv
Copy link
Contributor

  1. For the Outlined button in Bootstrap:

When we focus the outlined button in Bootstrap, the icon color remains loaded from --icon-color (blue), which makes it disappear because the background also turns blue on focus.

bootstrap-outlined.mp4
  1. For the Flat button in all themes:

When we focus + click -> the border color loads from --focus-visible-border-color instead of --focus-border-color. This results in --focus-border-color not being used anywhere in the Flat button.

  1. In the Indigo theme, all button types have the following behaviour (not sure if this is intended):

When we focus + click → the icon inside the button uses --icon-color-hover, while all other themes use the --focus-foreground for the icon color in that state.

When we click → the icon inside the button uses --icon-color-hover, while all other themes use the --active-foreground for the icon color in that state.

@rkaraivanov rkaraivanov merged commit fe886d9 into master Nov 28, 2025
7 checks passed
@rkaraivanov rkaraivanov deleted the didimmova/update-buttons-theme branch November 28, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to correctly style the button using Sass themes from theming package

6 participants