Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C closes down instance instead of cancelling TG token verification #257

Open
susikaman opened this issue Apr 30, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@susikaman
Copy link
Contributor

Bug explanation

When adding a new TG token, Ikabot checks for a response once per second. It gives the option to cancel the checking by Ctrl+C, but instead of just cancelling and returning to the menu, it closes down the entire bot.

Operating System

Ubuntu

Ikabot installation

I downloaded the pre-built Windows binary

Ikabot version

Latest

Python version

3.10.12

@susikaman susikaman added bug Something isn't working evaluation required Items is pending review or evaluation by the team labels Apr 30, 2024
@ikagod ikagod removed the evaluation required Items is pending review or evaluation by the team label May 5, 2024
@ikagod
Copy link
Collaborator

ikagod commented May 5, 2024

I could not reproduce this bug neither on the .exe or on the python version. It simply returns the the main menu for me.

I do agree with the fact that the entire multiprocessing system we have for ikabot is incredibly buggy and unstable. I think the structure of ikabot is due for a rewrite, and that is why I have proposed to switching to a multi-threaded mode of execution instead of a multi-process one. This would also allow us to save a background tasks configuration and schedule it to run again if it fails or if the user wants to reuse their configuration.

I also believe its time to decrypt the session data and perhaps use encryption only on the cookies and telegram token instead of encrypting the entire file. Perhaps we could also give the use the option to disable encryption on their session data

@susikaman
Copy link
Contributor Author

I could not reproduce this bug neither on the .exe or on the python version. It simply returns the the main menu for me.

I do agree with the fact that the entire multiprocessing system we have for ikabot is incredibly buggy and unstable. I think the structure of ikabot is due for a rewrite, and that is why I have proposed to switching to a multi-threaded mode of execution instead of a multi-process one. This would also allow us to save a background tasks configuration and schedule it to run again if it fails or if the user wants to reuse their configuration.

I also believe its time to decrypt the session data and perhaps use encryption only on the cookies and telegram token instead of encrypting the entire file. Perhaps we could also give the use the option to disable encryption on their session data

I agree on the optional encryption part. It would make identifying and modifying personal .ikabot files far more easy.

And yes, the current multi-processing handles quite differently between Linux and Windows systems. One works for another while acts differently on the other. Multi-threading with a dynamic list of tasks sounds really sweet for me, no more re-launching of some "basic tasks" which are supposed to be running 24/7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants