Merge branch 'release'

Author: ImSejin

.github/workflows/codeql.yml

@@ -0,0 +1,41 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "dev" ]
+  pull_request:
+    branches: [ "dev" ]
+  schedule:
+    - cron: "19 12 * * 5"
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ java ]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          queries: +security-and-quality
+
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2
+        with:
+          category: "/language:${{ matrix.language }}"

CHANGELOG.md

@@ -1,10 +1,27 @@
 # Table of Contents
 
+- [v3.0.3](#v303): 2023-01-03
 - [v3.0.2](#v302): 2022-12-18
 - [v3.0.1](#v301): 2022-12-16
 - [v3.0.0](#v300): 2022-12-14
 - [v2.9.0](#v290): 2022-02-20
 
+# v3.0.3
+
+## Dependencies
+
+- ⬆️ Upgrade: dependency `common-utils` from `0.13.0` to `0.14.0`
+- ⬆️ Upgrade: dependency `annotations` from `23.0.0` to `23.1.0`
+- ⬆️ Upgrade: dependency `slf4j-api` from `2.0.4` to `2.0.6`
+- ⬆️ Upgrade: dependency `logback-classic` from `1.3.5` to `1.4.5`
+- ⬆️ Upgrade: test dependency `mockito-inline` from `4.10.0` to `4.11.0`
+- ⬆️ Upgrade: build dependency `gmavenplus-plugin` from `1.13.1` to `2.1.0`
+
+## Troubleshooting
+
+- 🐞 Fix: termination of application
+- 🐞 Fix: unreproducible issue that failure to get image count
+
 # v3.0.2
 
 ## Dependencies

README.md

@@ -7,18 +7,21 @@
 <p align="center">Downloader for lezhin comics</p>
 
 <p align="center">
-    <a href="https://lgtm.com/projects/g/ImSejin/lezhin-comics-downloader/context:java">
-        <img alt="Lgtm grade" src="https://img.shields.io/lgtm/grade/java/github/ImSejin/lezhin-comics-downloader.svg?logo=&logoWidth=&label=lgtm%3A%20code%20quality&&style=flat-square"/>
+    <a href="https://sonarcloud.io/summary/new_code?id=ImSejin_lezhin-comics-downloader">
+        <img alt="Sonarcloud Security Rating" src="https://sonarcloud.io/api/project_badges/measure?project=ImSejin_lezhin-comics-downloader&metric=security_rating"/>
+    </a>
+    <a href="https://sonarcloud.io/summary/new_code?id=ImSejin_lezhin-comics-downloader">
+        <img alt="Sonarcloud Maintainability Rating" src="https://sonarcloud.io/api/project_badges/measure?project=ImSejin_lezhin-comics-downloader&metric=sqale_rating"/>
     </a>
     <a href="https://app.codacy.com/gh/ImSejin/lezhin-comics-downloader/dashboard">
-        <img alt="Codacy grade" src="https://img.shields.io/codacy/grade/1a2400c31a8346ddbf108fb3ac78f481?label=codacy%3A%20code%20quality&style=flat-square">
+        <img alt="Codacy grade" src="https://img.shields.io/codacy/grade/1a2400c31a8346ddbf108fb3ac78f481?style=flat&logo=codacy">
     </a>
-    <img alt="jdk11" src="https://img.shields.io/badge/jdk-11-orange?style=flat-square">
+    <img alt="jdk11" src="https://img.shields.io/badge/jdk-11-orange?style=flat">
     <br/>
-    <img alt="GitHub All Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/total?style=flat-square">
-    <img alt="GitHub Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/latest/total?style=flat-square">
+    <img alt="GitHub All Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/total?style=flat">
+    <img alt="GitHub Releases" src="https://img.shields.io/github/downloads/imsejin/lezhin-comics-downloader/latest/total?style=flat">
     <a href="https://github.com/ImSejin/lezhin-comics-downloader/releases/latest">
-        <img alt="Latest release" src="https://img.shields.io/github/v/release/ImSejin/lezhin-comics-downloader?color=orange&style=flat-square">
+        <img alt="Latest release" src="https://img.shields.io/github/v/release/ImSejin/lezhin-comics-downloader?color=orange&style=flat">
     </a>
 </p>
 

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>io.github.imsejin</groupId>
     <artifactId>lezhin-comics-downloader</artifactId>
-    <version>3.0.2</version>
+    <version>3.0.3</version>
     <packaging>jar</packaging>
 
     <name>Lezhin Comics Downloader</name>
@@ -41,23 +41,23 @@
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 
         <!-- Dependency versions -->
-        <common-utils.version>0.13.0</common-utils.version>
+        <common-utils.version>0.14.0</common-utils.version>
         <commons-cli.version>1.5.0</commons-cli.version>
         <progressbar.version>0.9.4</progressbar.version>
         <reftrofit.version>2.9.0</reftrofit.version>
         <selenium.version>4.6.0</selenium.version>
         <reflections.version>0.10.2</reflections.version>
         <lombok.version>1.18.24</lombok.version>
         <mapstruct.version>1.5.3.Final</mapstruct.version>
-        <jetbrains-annotations.version>23.0.0</jetbrains-annotations.version>
-        <logback-classic.version>1.3.5</logback-classic.version>
-        <slf4j-api.version>2.0.4</slf4j-api.version>
+        <jetbrains-annotations.version>23.1.0</jetbrains-annotations.version>
+        <logback-classic.version>1.4.5</logback-classic.version>
+        <slf4j-api.version>2.0.6</slf4j-api.version>
 
         <!-- Test dependency versions -->
         <junit5.version>5.9.1</junit5.version>
         <assertj.version>3.23.1</assertj.version>
         <spock.version>2.3-groovy-4.0</spock.version>
-        <mockito.version>4.10.0</mockito.version>
+        <mockito.version>4.11.0</mockito.version>
     </properties>
 
     <!-- Enables to build on development environment -->
@@ -329,7 +329,7 @@
             <plugin>
                 <groupId>org.codehaus.gmavenplus</groupId>
                 <artifactId>gmavenplus-plugin</artifactId>
-                <version>1.13.1</version>
+                <version>2.1.0</version>
                 <executions>
                     <execution>
                         <goals>

src/main/java/io/github/imsejin/dl/lezhin/Application.java

@@ -58,11 +58,11 @@ public static void main(String[] args) {
             for (Processor processor : processors) {
                 Object attribute = processor.process(context);
                 context.add(attribute);
-//                context = ProcessContext.of(context, attribute);
             }
         } catch (Exception e) {
-            WebBrowser.quitIfInitialized();
             Loggers.getLogger().error("Failed to perform a process", e);
+        } finally {
+            WebBrowser.quitIfInitialized();
         }
     }
 

src/main/java/io/github/imsejin/dl/lezhin/process/impl/AccessTokenProcessor.java

@@ -96,7 +96,7 @@ public AccessToken process(ProcessContext context) throws AccessTokenNotFoundExc
         }
 
         AccessToken accessToken = new AccessToken(token);
-        Loggers.getLogger().info("Successfully logged in: access token({})", accessToken.getValue());
+        Loggers.getLogger().info("Successfully logged in: access token({})", token);
 
         return accessToken;
     }

src/main/java/io/github/imsejin/dl/lezhin/process/impl/DownloadProcessor.java

@@ -66,18 +66,18 @@
 @ProcessSpecification(dependsOn = DirectoryCreationProcessor.class)
 public class DownloadProcessor implements Processor {
 
-    private static final Map<Locale, DownloadProcessor> IMPLEMENTATION_MAP = Map.ofEntries(
-            Map.entry(Locale.KOREA, new KoreanImpl()),
-            Map.entry(Locale.US, new EnglishImpl()),
-            Map.entry(Locale.JAPAN, new EnglishImpl())
+    private static final Map<Locale, ImageCountResolver> IMPLEMENTATION_MAP = Map.ofEntries(
+            Map.entry(Locale.KOREA, new UsingService()),
+            Map.entry(Locale.US, new VisitingPage()),
+            Map.entry(Locale.JAPAN, new VisitingPage())
     );
 
     @Override
     public Void process(ProcessContext context) throws DirectoryCreationException {
         Locale locale = context.getLanguage().getValue();
 
-        DownloadProcessor impl = IMPLEMENTATION_MAP.get(locale);
-        impl.prepare(context);
+        ImageCountResolver imageCountResolver = IMPLEMENTATION_MAP.get(locale);
+        imageCountResolver.prepare(context);
 
         AuthorityService service = new AuthorityService(locale, context.getAccessToken().getValue());
 
@@ -95,7 +95,18 @@ public Void process(ProcessContext context) throws DirectoryCreationException {
                 continue;
             }
 
-            int imageCount = impl.getImageCountOfEpisode(context, episode);
+            int imageCount;
+            try {
+                imageCount = imageCountResolver.getImageCountOfEpisode(context, episode);
+            } catch (NullPointerException ignored) {
+                // TODO: Remove the below code if solve the issue (#153).
+                //       See https://github.com/ImSejin/lezhin-comics-downloader/issues/153
+                UsingService impl = (UsingService) imageCountResolver;
+                Loggers.getLogger().debug("Failed to get image count of episode[{}]: (UsingService.imageCountMap={})",
+                        episode, impl.imageCountMap);
+                imageCountResolver = IMPLEMENTATION_MAP.get(Locale.US);
+                imageCount = imageCountResolver.getImageCountOfEpisode(context, episode);
+            }
 
             // If episode has no image, skips this episode.
             if (imageCount < 1) {
@@ -141,20 +152,21 @@ public Void process(ProcessContext context) throws DirectoryCreationException {
 
     // -------------------------------------------------------------------------------------------------
 
-    void prepare(ProcessContext context) {
-    }
+    /**
+     * @since 3.0.3
+     */
+    private interface ImageCountResolver {
+        default void prepare(ProcessContext context) {
+        }
 
-    int getImageCountOfEpisode(ProcessContext context, Episode episode) {
-        throw new UnsupportedOperationException("Not implemented");
+        int getImageCountOfEpisode(ProcessContext context, Episode episode);
     }
 
-    // -------------------------------------------------------------------------------------------------
-
-    private static final class KoreanImpl extends DownloadProcessor {
+    private static final class UsingService implements ImageCountResolver {
         private Map<String, Integer> imageCountMap;
 
         @Override
-        void prepare(ProcessContext context) {
+        public void prepare(ProcessContext context) {
             UUID token = context.getAccessToken().getValue();
             String contentAlias = context.getContent().getAlias();
             EpisodeImageCountService service = new EpisodeImageCountService(token);
@@ -163,14 +175,14 @@ void prepare(ProcessContext context) {
         }
 
         @Override
-        int getImageCountOfEpisode(ProcessContext context, Episode episode) {
+        public int getImageCountOfEpisode(ProcessContext context, Episode episode) {
             return this.imageCountMap.get(episode.getName());
         }
     }
 
-    private static final class EnglishImpl extends DownloadProcessor {
+    private static final class VisitingPage implements ImageCountResolver {
         @Override
-        int getImageCountOfEpisode(ProcessContext context, Episode episode) {
+        public int getImageCountOfEpisode(ProcessContext context, Episode episode) {
             Language language = context.getLanguage();
 
             String episodeUrl;