From 18fbd062aa197724fdee5c9bcb9aeb303bcc91ea Mon Sep 17 00:00:00 2001
From: Dan LaManna <dan.lamanna@kitware.com>
Date: Sun, 11 Jan 2026 20:31:22 -0500
Subject: [PATCH] Blind all study interfaces to metadata

---
 .../templates/core/partials/image_thumb.html  |  4 +--
 .../studies/partials/study_image.html         |  4 +--
 .../templates/studies/study_task_detail.html  |  2 +-
 isic/studies/tests/test_views.py              | 33 +++++++++++++++++++
 4 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/isic/core/templates/core/partials/image_thumb.html b/isic/core/templates/core/partials/image_thumb.html
index e19e1918..2d91bf04 100644
--- a/isic/core/templates/core/partials/image_thumb.html
+++ b/isic/core/templates/core/partials/image_thumb.html
@@ -10,8 +10,6 @@
 
 <template x-if="true">
   <div x-show="open">
-    {% block image_modal %}
-      {% include 'core/partials/image_modal.html' with include_metadata=1 %}
-    {% endblock %}
+    {% include 'core/partials/image_modal.html' with include_metadata=include_metadata|default_if_none:1 %}
   </div>
 </template>
diff --git a/isic/studies/templates/studies/partials/study_image.html b/isic/studies/templates/studies/partials/study_image.html
index 1d2f5404..afa8d76b 100644
--- a/isic/studies/templates/studies/partials/study_image.html
+++ b/isic/studies/templates/studies/partials/study_image.html
@@ -1,7 +1,7 @@
 {% extends "core/partials/image.html" %}
 
-{% block image_modal %}
-  {% include 'core/partials/image_modal.html' with include_metadata=0 %}
+{% block thumb %}
+  {% include 'core/partials/image_thumb.html' with include_metadata=0 %}
 {% endblock %}
 
 {% block below_thumb %}
diff --git a/isic/studies/templates/studies/study_task_detail.html b/isic/studies/templates/studies/study_task_detail.html
index bb946e01..067ad761 100644
--- a/isic/studies/templates/studies/study_task_detail.html
+++ b/isic/studies/templates/studies/study_task_detail.html
@@ -60,7 +60,7 @@
 
         <template x-if="true">
           <div x-show="open">
-            {% include 'core/partials/image_modal.html' with image=study_task.image %}
+            {% include 'core/partials/image_modal.html' with image=study_task.image include_metadata=False %}
           </div>
         </template>
       </div>
diff --git a/isic/studies/tests/test_views.py b/isic/studies/tests/test_views.py
index 17edd799..3132bd96 100644
--- a/isic/studies/tests/test_views.py
+++ b/isic/studies/tests/test_views.py
@@ -2,6 +2,7 @@
 from django.utils import timezone
 import pytest
 
+from isic.core.tests.factories import ImageFactory
 from isic.factories import UserFactory
 from isic.studies.models import Question, Response
 from isic.studies.models.question_choice import QuestionChoice
@@ -141,3 +142,35 @@ def test_multiselect_question_empty_response(staff_client) -> None:
     lines = r.content.decode().splitlines()
     assert len(lines) == 2
     assert lines[1].endswith(",")
+
+
+@pytest.mark.django_db
+def test_study_detail_hides_image_metadata(client):
+    image = ImageFactory.create(public=False, accession__sex="male")
+    study = StudyFactory.create(public=True)
+    study.collection.images.add(image)
+    study_task = StudyTaskFactory.create(study=study, image=image)
+
+    client.force_login(study_task.annotator)
+
+    r = client.get(reverse("study-detail", args=[study.pk]))
+    assert r.status_code == 200
+    content = r.content.decode()
+
+    assert "male" not in content
+
+
+@pytest.mark.django_db
+def test_study_task_detail_hides_image_metadata(client):
+    image = ImageFactory.create(public=False, accession__sex="male")
+    study = StudyFactory.create(public=True)
+    study.collection.images.add(image)
+    study_task = StudyTaskFactory.create(study=study, image=image)
+
+    client.force_login(study_task.annotator)
+
+    r = client.get(reverse("study-task-detail", args=[study_task.pk]))
+    assert r.status_code == 200
+    content = r.content.decode()
+
+    assert "male" not in content