-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Object Class Display on Hover #195
Comments
So we'll show the ROI number and the class nickname. Do we need anything else? |
Nothing is shown on mouse click when Slim is deployed in view-only mode (as it is in IDC). I suggest we should include in the tooltip the same information that is currently shown for that annotation in the right-hand slide panel. What do you think? |
Let's change the deploy configuration for the test instance to be "read only" so we test this feature in the same way as it would appear in IDC deployment. Let's just do the double-click/click for now, and after testing that discuss if we still want to have hover support. |
@fedorov I updated the env https://slim-dmv.web.app/ |
It does - thank you! |
@fedorov does this mean that there is no reason to keep this issue open, or should something be developed? |
I reviewed what is available right now. I think there is a bug or I don't understand something, but I do not think it makes sense to have 3 states for the annotation highlights (yellow, bright blue and pale blue). Is this a bug? Second, I think showing ROI information on hover would be very helpful, so let's keep this ticket open. |
@fedorov Do you think this bug was caused by this change, or is it an unrelated/new issue found in Slim? |
I do not know. Click to show ROI information was not enabled in the past, so I do not have experience using it. We don't have it enabled in the IDC deployment either. |
Could you please share the env, and server used so @pedrokohler or myself can replicate this issue? |
This is the DICOM store: https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb. I was testing with your https://slim-dmv.web.app/ instance. |
@pedrokohler please replicate this issue locally using the master branch. If it's reproducible using master then create a new issue for it and attach the video shared by Andrey. I guess that we have two highlighting here which are only noticeable when testing against SR annotations (one highlight from OpenLayers and another from slim). |
Implement Object Class Display on Hover
Description
Implement a feature that allows users to hover over an object and display its class or a class nickname. This enhancement will provide users with quick access to important information about objects, improving usability and workflow efficiency.
Acceptance Criteria
The viewer currently displays Region of Interest (ROI) number and details in a tooltip upon mouse-click. This feature requires retesting to ensure its functionality extends to all annotations.
From #184
The text was updated successfully, but these errors were encountered: