Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative paths are absolute. #98

Closed
TheAifam5 opened this issue Aug 18, 2018 · 1 comment
Closed

Relative paths are absolute. #98

TheAifam5 opened this issue Aug 18, 2018 · 1 comment

Comments

@TheAifam5
Copy link
Contributor

TheAifam5 commented Aug 18, 2018 •
edited
Loading

Hey,

Based on issue: ImmoweltGroup/create-react-microservice#217, i noticed that the variables on Windows: relativeSrcFilePath and relativeDistFilePath are the same, that is because you adding path.sep there, and that's not a relative paths, but absolute.
Using replace like this makes absolutely no sense here (file template.js
Using just path.relative can done the same thing and much safer.

The pull request is on the way.

Regards,
TheAifam5
@TheAifam5 TheAifam5 mentioned this issue Aug 18, 2018
Merged
@TheAifam5
Copy link
Contributor Author

The commit is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheAifam5