Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow support for all selectors spec files #67

Open
Inkdpixels opened this issue Dec 21, 2017 · 0 comments
Open

Add flow support for all selectors spec files #67

Inkdpixels opened this issue Dec 21, 2017 · 0 comments

Comments

@Inkdpixels
Copy link
Collaborator

Describe the problem:

As of now the scaffold does not provide flow support for the jest spec files of reselect selectors. The reason why we haven't added it in the first place was that the selector is typed with the global StateType of the application, and the tests only provide a subset of it since it would otherwise increase the maintainability of the tests into nowhere.

A possible solution would be to either add a } | Object to the global StateType declaration, but this solution would also lead to less feedback from flow in the real world usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant