Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass chainId on request #49

Open
janndriessen opened this issue May 16, 2024 · 0 comments
Open

refactor: pass chainId on request #49

janndriessen opened this issue May 16, 2024 · 0 comments

Comments

@janndriessen
Copy link
Collaborator

janndriessen commented May 16, 2024

If you search for chainId in the project, you'll find that almost all builders and quote providers fetch the network's chainId. This ticket is to check how expensive this is and if chainId should rather be passed as part of the build/quote request. This would:

  • avoid an extra potential network call? (performance)
  • make it more clear what the user wants to request*

* up to the SDK to check if the request chainId and the provider's actually connected chainId is the same. Or is the users responsibility?

@janndriessen janndriessen changed the title pass chainId refactor: pass chainId on request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant