Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance quick stats #1706

Merged
merged 14 commits into from
Jan 6, 2025
Merged

feat: enhance quick stats #1706

merged 14 commits into from
Jan 6, 2025

Conversation

janndriessen
Copy link
Collaborator

@janndriessen janndriessen commented Dec 22, 2024 •
edited
Loading

Summary of Changes

  • Moves more data into quick stats
By submitting this pull request, you are confirming the following to be true:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the master at IndexCoop/index-app.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
index-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 3:58pm

@janndriessen janndriessen marked this pull request as ready for review January 2, 2025 12:46
@janndriessen janndriessen requested review from tokdaniel and 0xonramp and removed request for tokdaniel January 2, 2025 14:25
0xonramp
0xonramp reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@0xonramp 0xonramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few smol nits but LGTM

src/app/leverage/components/stats/leverage-selector-container.tsx Outdated Show resolved Hide resolved
src/app/leverage/components/stats/use-quick-stats.tsx Outdated Show resolved Hide resolved
@janndriessen
Copy link
Collaborator Author

few smol nits but LGTM

both fixed in #1718

@janndriessen
refactor: quotes hook (#1718)
b651558 
* add use quote result

* move best quote

* add reset quote

* update earn provider

* update leverage provider

* add use tx review

* rename to use prepare tx review

* add biome json to avoid vscode formatting issues

* use format percentage

* remove obsolete spread syntax
@0xonramp 0xonramp self-requested a review January 6, 2025 15:40
0xonramp
0xonramp reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@0xonramp 0xonramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two smol nits

biome.json Show resolved Hide resolved
src/app/leverage/components/stats/leverage-selector-container.tsx Outdated Show resolved Hide resolved
@janndriessen janndriessen merged commit 6bd1055 into master Jan 6, 2025
3 checks passed
@janndriessen janndriessen deleted the feat/enhance-quick-stats branch January 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xonramp 0xonramp 0xonramp left review comments

@tokdaniel tokdaniel Awaiting requested review from tokdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janndriessen @0xonramp