Two bugs in bashcompletion for classical naval app

[remort]

Classical naval app is in my /usr/bin/naval file:

#!/usr/bin/python3

"""Naval Fate.

Usage:
  naval_fate.py ship new <name>...
  naval_fate.py ship <name> move <x> <y> [--speed=<kn>]
  naval_fate.py ship shoot <x> <y>
  naval_fate.py mine (set|remove) <x> <y> [--moored | --drifting]
  naval_fate.py (-h | --help)
  naval_fate.py --version

Options:
  -h --help     Show this screen.
  --version     Show version.
  --speed=<kn>  Speed in knots [default: 10].
  --moored      Moored (anchored) mine.
  --drifting    Drifting mine.

"""
from docopt import docopt


if __name__ == '__main__':
    arguments = docopt(__doc__, version='Naval Fate 2.0')
    print(arguments)

Generate autocomletion for that via docopt-completion naval and have 2 bugs:

1. commands completes with variety of files in current dir except naval commands. Looking in bashcompletion file gave me that:
   COMPREPLY=( $( compgen -fW ' move shoot new' -- $cur) )

it should be just compgen -W, not -fW. f id sor files, i suppose.

2. pressing tab after naval mine set ..pressing tab.. gives me nothing or filnames in current dir. But it should print me --moored --drifting and probably <x> <y>.

If i type naval mine set 10 10 ..press tab.. it gives me nothing neither.

[wiggin15]

There is a comment in the code that explains both of these issues:

    # add -f (show files in completion options) if there are arguments in the current section
    # in this case there are (usually) no subcommands to suggest, and only flags, so it's ok to suggest files,
    # and if the user types "-" first, then only the flags will be suggested

This means that if there are arguments, like , then the only suggestion that can be offered is files (we don't want to add the string "" to the command, this is usually not valid input). For flags, the user first has to type "-" and only then flags are offered as completion suggestions (if the next input is supposed to be an argument, , we can't be sure the user wants to add flags at this point).

zsh's completion system is a little better, and there, in the case of arguments, the system will output the argument name ("") as a message, but not as a completion suggestion, so it will not be completed into the command line. I put a little less effort into bash's completion system, which doesn't support this type of "messages" AFAIK.