From b44a573b73015d7c3353680681f46da650cfd275 Mon Sep 17 00:00:00 2001 From: emalfroy Date: Fri, 17 Nov 2023 16:46:49 +0100 Subject: [PATCH 1/2] fix: add addressmatch extensions --- .../AddressMatch/Extensions.cs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/AddressRegistry.Api.Oslo/AddressMatch/Extensions.cs b/src/AddressRegistry.Api.Oslo/AddressMatch/Extensions.cs index aaebb88fd..1c6f25469 100644 --- a/src/AddressRegistry.Api.Oslo/AddressMatch/Extensions.cs +++ b/src/AddressRegistry.Api.Oslo/AddressMatch/Extensions.cs @@ -42,6 +42,9 @@ public static string ToggleAbbreviations(this string input) if (input.Contains("o.l.v.")) return input.Replace("o.l.v.", "Onze Lieve Vrouw"); + if (input.Contains("onze-lieve-")) + return input.Replace("onze-lieve-", "O.L. "); + if (input.Contains("sint")) return input.Replace("sint", "st."); @@ -78,6 +81,15 @@ public static string ToggleAbbreviations(this string input) if (input.EndsWith("str.")) return input.Replace("str.", "straat"); + if (input.StartsWith("heilige")) + return input.Replace("heilige", "h"); + + if (input.StartsWith("heilig")) + return input.Replace("heilig", "h"); + + if (input.StartsWith("k.")) + return input.Replace("k.", "koning"); + return input; } } From 56a6096d153491a1ffbb319b6ff03f96d3a6ff25 Mon Sep 17 00:00:00 2001 From: emalfroy Date: Tue, 21 Nov 2023 09:25:48 +0100 Subject: [PATCH 2/2] test: add fuzzymatching tests --- .../ApiTests/AddressMatch/AddressMatchV2Tests.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/AddressRegistry.Tests/ApiTests/AddressMatch/AddressMatchV2Tests.cs b/test/AddressRegistry.Tests/ApiTests/AddressMatch/AddressMatchV2Tests.cs index 8afa672e0..506e2d3eb 100644 --- a/test/AddressRegistry.Tests/ApiTests/AddressMatch/AddressMatchV2Tests.cs +++ b/test/AddressRegistry.Tests/ApiTests/AddressMatch/AddressMatchV2Tests.cs @@ -273,6 +273,11 @@ public async Task CanFindFusieGemeenteByNiscode() [InlineData("evergreen terras", "Evergreen Terrace")] // case insensitive [InlineData("St-Evergreen Terrace", "Sint-Evergreen Terrace")] // replace abreviations in input [InlineData("Onze Lieve Vrouw-Evergreen Terrace", "O.l.v.-Evergreen Terrace")] // replace abreviations in existing straatnaam + [InlineData("onze-lieve-vrouwemarkt", "O.-L.-Vrouwemarkt")] // replace abreviations in existing straatnaam + [InlineData("onze-lieve-vrouwstraat", "O.-L.-Vrouwstraat")] // replace abreviations in existing straatnaam + [InlineData("Heilig Hartlaan", "H.-Hartlaan")] // replace abreviations in existing straatnaam + [InlineData("Heilige Hartlaan", "H.-Hartlaan")] // replace abreviations in existing straatnaam + [InlineData("k.elisabethlaan", "Koningin Elisabethlaan")] // replace abreviations in existing straatnaam [InlineData("Clevergreen Terrace Avenue", "Evergreen")] // containment of existing straatnaam [InlineData("Evergreen", "Clevergreen Terrace Avenue")] // containment of input [InlineData("Trammesantlei", "Evergreen Terrace", false)] // no match