Skip to content

Commit 996c616

Browse files
committed
Fix wrong ca bundle for admission webhook
Signed-off-by: Timothy Lee <ctiml@infuseai.io>
1 parent fbacd49 commit 996c616

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

chart/templates/_helper.tpl

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ primehub deployment
247247
primehub admission
248248
*/}}
249249
{{- define "primehub-admission.webhook-certs.manage" -}}
250-
{{- $data := (dict "cert" "" "key" "" "test" "") }}
250+
{{- $data := (dict "cacert" "" "cert" "" "key" "") }}
251251
{{- $secretData := (lookup "v1" "Secret" .Release.Namespace "primehub-admission-webhook-certs").data -}}
252252
{{- if $secretData }}
253253
{{- if hasKey $secretData "cert.pem" }}
@@ -256,17 +256,16 @@ primehub admission
256256
{{- if hasKey $secretData "key.pem" }}
257257
{{- $_ := set $data "key" (index $secretData "key.pem" | quote) }}
258258
{{- end -}}
259-
{{- $_ := set $data "test" "from secret" }}
260259
{{- else }}
261260
{{- $ca := genCA "primehub-admission-webhook-certs" 3650 }}
261+
{{- $_ := set $data "cacert" ($ca.Cert | b64enc | quote) }}
262262
{{- $cn := "primehub-admission" }}
263263
{{- $altName1 := printf "%s.%s" $cn .Release.Namespace }}
264264
{{- $altName2 := printf "%s.%s.svc" $cn .Release.Namespace }}
265265
{{- $altNames := (list $altName1 $altName2) }}
266266
{{- $cert := genSignedCert $cn nil $altNames 3650 $ca }}
267-
{{- $_ := set $data "cert" ($ca.Cert | b64enc | quote) }}
268-
{{- $_ := set $data "key" ($ca.Key | b64enc | quote) }}
269-
{{- $_ := set $data "test" "gen ca" }}
267+
{{- $_ := set $data "cert" ($cert.Cert | b64enc | quote) }}
268+
{{- $_ := set $data "key" ($cert.Key | b64enc | quote) }}
270269
{{- end -}}
271270
{{- $data | toYaml -}}
272271
{{- end -}}

chart/templates/admission/webhook.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ webhooks:
1212
name: primehub-admission
1313
namespace: {{ .Release.Namespace }}
1414
path: "/image-mutation"
15-
caBundle: {{ get $data "cert" }}
15+
caBundle: {{ get $data "cacert" }}
1616
rules:
1717
- operations: [ "CREATE" ]
1818
apiGroups: ["*"]
@@ -36,7 +36,7 @@ webhooks:
3636
name: primehub-admission
3737
namespace: {{ .Release.Namespace }}
3838
path: /pvc-check
39-
caBundle: {{ get $data "cert" }}
39+
caBundle: {{ get $data "cacert" }}
4040
rules:
4141
- operations: [ "CREATE" ]
4242
apiGroups: ["*"]
@@ -60,7 +60,7 @@ webhooks:
6060
name: primehub-admission
6161
namespace: {{ .Release.Namespace }}
6262
path: "/"
63-
caBundle: {{ get $data "cert" }}
63+
caBundle: {{ get $data "cacert" }}
6464
rules:
6565
- operations: [ "CREATE" ]
6666
apiGroups: ["*"]
@@ -84,7 +84,7 @@ webhooks:
8484
name: primehub-admission
8585
namespace: {{ .Release.Namespace }}
8686
path: /license-check
87-
caBundle: {{ get $data "cert" }}
87+
caBundle: {{ get $data "cacert" }}
8888
failurePolicy: Ignore
8989
namespaceSelector:
9090
matchLabels:

0 commit comments

Comments
 (0)