Wrap errors in Error subclasses #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

markusjohnsson opened this issue Feb 8, 2016 · 1 comment

Contributor

markusjohnsson commented Feb 8, 2016

At places, we throw Error. At other places we throw strings or anonymous type objects. We should always throw proper Error subclasses.

Contributor Author

markusjohnsson commented Feb 8, 2016

Also, look into why we don't get a good output of the message from ResolveError (in Safari at least).

EDIT: fixed in master. message has to be set explicitly in Error subclasses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment