Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @ezs/conditor package (rnsr) #104

Open
NicolasKieffer opened this issue Oct 13, 2020 · 5 comments · May be fixed by #127
Open

Update @ezs/conditor package (rnsr) #104

NicolasKieffer opened this issue Oct 13, 2020 · 5 comments · May be fixed by #127

Comments

@NicolasKieffer
Copy link
Collaborator

Update & fix "affAlign" feature.
NicolasKieffer pushed a commit that referenced this issue Oct 14, 2020
fix: 🐛 fix affAlign feature of conditor package
efab1bd 
✅ Closes: #104
@parmentf
Copy link
Collaborator

Strange, according to the commit message (Closes: #104), this issue should be closed.

@NicolasKieffer
Copy link
Collaborator Author

NicolasKieffer commented Jan 19, 2021 •
edited
Loading

PR (master <- fix-issue-104) had not been made yet, that's why I had not closed this issue.
Fix was only available on branch fix-issue-104.

@parmentf
Copy link
Collaborator

Oh, thanks Nicolas. I did not realize that. :)

@parmentf parmentf linked a pull request Jan 25, 2021 that will close this issue
Open
@parmentf
Copy link
Collaborator

I found not tests that were modified or added.
This branch broke 16 tests.
The only way or me to fix them was to go back to the original code (except for a minor change).

I would like to have new tests, to show what was intended here.

@NicolasKieffer
Copy link
Collaborator Author

NicolasKieffer commented Jan 27, 2021 •
edited
Loading

I did not had time to correct unit tests.

More infos about changes here and here.

Most important change was RegExp "bugs" ("-" instead of "-"). There were other minors changes to increase "recall".

Valérie should have more infos about "why".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue 104 Inist-CNRS/ezs
2 participants
@parmentf @NicolasKieffer