-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made user registration page responsive under #271 #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
good job |
codewarnab
approved these changes
May 29, 2024
rishicds
approved these changes
May 30, 2024
fix conflicts @Priyal208 |
fix the conflicts please @Priyal208 |
yes |
done @rishicds |
good job @Priyal208 |
thank you |
Hello @rishicds this code is broken please review it once and revert the changes |
right |
codewarnab
added a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User registration page was made responsive under issue assigned to me #271 , i made it responsive using tailwind, fixed margin and padding , made form and image appear in row in mobile view and coloumn in desktop view, adjusted font size for different devices
I did remove image of dog in mobile view as you told me so
Related Issue
Related to #252 and part of #242
GSsoc #271
Screenshots / GIFs (if applicable)
BEFORE(MOBILE VIEW):


AFTER(MOBILE AND DESKTOP VIEW) :


Checklist:
Additional Notes
I deleted old PR and forked new one as you told me since it had earlier commits