Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spec'ed minimal preset SLOTS_PER_EPOCH = 8 #65

Closed
dapplion opened this issue Nov 18, 2022 · 5 comments
Closed

Use spec'ed minimal preset SLOTS_PER_EPOCH = 8 #65

dapplion opened this issue Nov 18, 2022 · 5 comments

Comments

@dapplion
Copy link

SLOTS_PER_EPOCH: 3

value should be 8 to match client's baked in minimal preset

@jimmygchen
Copy link
Contributor

@dapplion is minimal the default preset for Lodestar?
The PRESET_BASE is currently not defined in the chain-config.yml file, and if I remember correctly Prysm loads the mainnet preset as default.

I'm trying to get Lighthouse to run with this config (without a PRESET_BASE defined) but it doesn't allow it, so I think we may need to be explicit on defining this.

@dapplion
Copy link
Author

@dapplion is minimal the default preset for Lodestar?

Default preset is mainnet, but we support minimal without any code modifications. That's gonna be the case for most CLs, so using the stardard minimal preset will make interop much easier. If you need faster chains, just pick a short SECONDS_PER_SLOT

@jimmygchen
Copy link
Contributor

Thanks @dapplion !

There's currently no PRESET_BASE specified in the chain-config.yaml file, so I guess we're using the mainnet preset? @Inphi and I ran into some issues getting Prysm to work with minimal preset, but would be great to switch over to minimal once we have it resolved.

I'm just trying to figure out whether we need to create a new preset for Lighthouse to interop, because the current chain config overrides the SLOTS_PER_EPOCH in the mainnet preset, and overriding preset config is not supported in Lighthouse due to this issue. So it would be easier if we switch over to minimal and keep SLOTS_PER_EPOCH to be 8 as you suggested.

@jimmygchen
Copy link
Contributor

Apologies, my questions above are probably not relevant to this issue, will bring this discussion elsewhere :)

@dapplion
Copy link
Author

dapplion commented Dec 4, 2022

Currently uses mainnet preset. No more cursed SLOTS_PER_EPOCH =D

SLOTS_PER_EPOCH: 32

@dapplion dapplion closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants