Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential mistake in koin-ktor documentation #1982

Open
dAnjou opened this issue Sep 16, 2024 · 0 comments
Open

Potential mistake in koin-ktor documentation #1982

dAnjou opened this issue Sep 16, 2024 · 0 comments

Comments

@dAnjou
Copy link

dAnjou commented Sep 16, 2024

In https://insert-koin.io/docs/reference/koin-ktor/ktor, it says:

Resolve from Ktor Request Scope (since 3.5.0)

You can declare components to live within Ktor request scope timeline. For this, you just need to declare your component inside a scope<ScopeRequest> section. Given a ScopeComponent class to instantiate on RequestScope, let's declare it:

scope<RequestScope>{
    scopedOf(::ScopeComponent)
}

Is it ScopeRequest or RequestScope?

I think it's the latter, because the former doesn't show up anywhere in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant