Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a fallback for empty screen names #505

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: use a fallback for empty screen names #505

merged 3 commits into from
Sep 13, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 5, 2024

Description of the change

Fallback to "N/A" when a screen with an empty screen name is observed, this prevents crashes in ScreenLoadingManager because the screen name is empty and prevents the screen change event from being dropped.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: INSD-12170

Fixes #504

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev changed the base branch from master to dev September 5, 2024 14:03
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 5, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 85.3% ✅

Generated by 🚫 dangerJS against 99eac5f

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit 4be7117 into dev Sep 13, 2024
11 checks passed
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the fix/empty-screen-name branch September 13, 2024 11:27
@a7medev a7medev mentioned this pull request Sep 17, 2024
Open
@sarahkhaledd sarahkhaledd added this to the 24Q3C2 milestone Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q3C2
Development

Successfully merging this pull request may close these issues.

InstabugNavigatorObserver errors when screen name is an empty string.
5 participants
@a7medev @InstabugCI @AndrewAminInstabug @sarahkhaledd @ahmedAlaaInstabug