Use _isdtype_impl in __array_namespace_info__ and isdtype

This change reduces redundancy

Author: ndgrigorian

dpctl/tensor/_array_api.py

@@ -23,35 +23,9 @@
     default_device_int_type,
 )
 
-__array_api_version__ = "2022.12"
-
-
-def _isdtype_impl(dtype, kind):
-    if isinstance(kind, dpt.dtype):
-        return dtype == kind
+from ._data_types import _isdtype_impl
 
-    elif isinstance(kind, str):
-        if kind == "bool":
-            return dtype.kind == "b"
-        elif kind == "signed integer":
-            return dtype.kind == "i"
-        elif kind == "unsigned integer":
-            return dtype.kind == "u"
-        elif kind == "integral":
-            return dtype.kind in "iu"
-        elif kind == "real floating":
-            return dtype.kind == "f"
-        elif kind == "complex floating":
-            return dtype.kind == "c"
-        elif kind == "numeric":
-            return dtype.kind in "iufc"
-        else:
-            raise ValueError(f"Unrecognized data type kind: {kind}")
-
-    elif isinstance(kind, tuple):
-        return any(_isdtype_impl(dtype, k) for k in kind)
-    else:
-        raise TypeError(f"Unsupported data type kind: {kind}")
+__array_api_version__ = "2022.12"
 
 
 class __array_namespace_info__:
@@ -88,7 +62,7 @@ def default_dtypes(self, device=None):
             device = dpctl.select_default_device()
         return {
             "real floating": default_device_fp_type(device),
-            "complex floating": default_device_complex_type,
+            "complex floating": default_device_complex_type(device),
             "integral": default_device_int_type(device),
             "indexing": default_device_index_type(device),
         }

dpctl/tensor/_data_types.py

@@ -50,20 +50,7 @@
 complex128 = dtype("complex128")
 
 
-def isdtype(dtype_, kind):
-    """isdtype(dtype, kind)
-
-    Returns a boolean indicating whether a provided `dtype` is
-    of a specified data type `kind`.
-
-    See [array API](array_api) for more information.
-
-    [array_api]: https://data-apis.org/array-api/latest/
-    """
-
-    if not isinstance(dtype_, dtype):
-        raise TypeError(f"Expected instance of `dpt.dtype`, got {dtype_}")
-
+def _isdtype_impl(dtype_, kind):
     if isinstance(kind, dtype):
         return dtype_ == kind
 
@@ -92,6 +79,23 @@ def isdtype(dtype_, kind):
         raise TypeError(f"Unsupported data type kind: {kind}")
 
 
+def isdtype(dtype_, kind):
+    """isdtype(dtype, kind)
+
+    Returns a boolean indicating whether a provided `dtype` is
+    of a specified data type `kind`.
+
+    See [array API](array_api) for more information.
+
+    [array_api]: https://data-apis.org/array-api/latest/
+    """
+
+    if not isinstance(dtype_, dtype):
+        raise TypeError(f"Expected instance of `dpt.dtype`, got {dtype_}")
+
+    return _isdtype_impl(dtype_, kind)
+
+
 def _get_dtype(inp_dt, sycl_obj, ref_type=None):
     """
     Type inference utility to construct data type