From dcb566a424a902af8ccb7e96021a3899e98c925b Mon Sep 17 00:00:00 2001 From: Oleksandr Pavlyk Date: Thu, 26 Oct 2023 15:24:17 -0500 Subject: [PATCH] Corrected logical error in can_use_reduce_over_group trait implementation --- dpctl/tensor/libtensor/include/kernels/reductions.hpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dpctl/tensor/libtensor/include/kernels/reductions.hpp b/dpctl/tensor/libtensor/include/kernels/reductions.hpp index d5fddce6ed..884a7c5461 100644 --- a/dpctl/tensor/libtensor/include/kernels/reductions.hpp +++ b/dpctl/tensor/libtensor/include/kernels/reductions.hpp @@ -50,12 +50,18 @@ namespace tensor namespace kernels { +template struct needs_workaround +{ + static constexpr bool value = + std::is_same_v> && + (std::is_same_v || std::is_same_v); +}; + template struct can_use_reduce_over_group { static constexpr bool value = sycl::has_known_identity::value && - !std::is_same_v && !std::is_same_v && - !std::is_same_v>; + !needs_workaround::value; }; template