maxFailures value of -1 is not honored

[skoranda]

If one sets in multi-context-broker.xml

-1

then instead of an "unlimited number of login failures" as indicated by the documentation the IdP will send the user back to the SP with a SAML error after the first login failure.

I believe this is because of this if() statement in MCBLoginServlet.java:

if (principal.getFailedCount() >= mcbConfig.getMaxFailures())

With maxFailures set to -1 that test will always be true after the first login failure.

Something like

if ((principal.getFailedCount() >= mcbConfig.getMaxFailures()) && (mcbConfig.getMaxFailures() != -1))

appears to fix the issue.

[paulhethmon]

Code fixed in v 1.2.2