Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we upstream these type classes? #512

Closed
locallycompact opened this issue Apr 9, 2024 · 7 comments
Closed

Should we upstream these type classes? #512

locallycompact opened this issue Apr 9, 2024 · 7 comments
Labels

Comments

@locallycompact
Copy link
Contributor

We have been using a type-class based wrapper around cardano-api to deal with era witnesses. The classes we have are similar to IsShelleyBasedEra from this repository and have consistent naming with it, and can be found here:

https://github.com/input-output-hk/hydra/tree/master/cardano-api-classy/src/Cardano/Api/Class

Wondering whether these are worth upstreaming here, as this library has a minimal footprint.

@smelc
Copy link
Contributor

smelc commented Apr 9, 2024

This is one for the grand masters of this repo 😆 cc @carbolymer @Jimbo4350 @newhoggy

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label May 10, 2024
@smelc
Copy link
Contributor

smelc commented May 13, 2024

cc @carbolymer @Jimbo4350 @newhoggy

@github-actions github-actions bot removed the Stale label May 14, 2024
@locallycompact
Copy link
Contributor Author

Could use an answer on this before we factor this out of our repository.

@carbolymer
Copy link
Contributor

I'd be for upstreaming. We can give it final shape on a PR level.

@locallycompact
Copy link
Contributor Author

Draft here #537

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants