Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Maybe ScriptHash from PReferenceScript #606

Open
Swordlash opened this issue Aug 2, 2024 · 6 comments · May be fixed by #642
Open

Remove redundant Maybe ScriptHash from PReferenceScript #606

Swordlash opened this issue Aug 2, 2024 · 6 comments · May be fixed by #642

Comments

@Swordlash
Copy link
Contributor

Hello, I have been asked a question "what is the script hash used for in PReferenceScript and when can you set it to Nothing"?

Currently the type PlutusScriptOrReferenceInput looks like this:

data PlutusScriptOrReferenceInput lang
  = PScript (PlutusScript lang)
  | -- | Needed to construct the redeemer pointer map
    -- in the case of minting reference scripts where we don't
    -- have direct access to the script
    PReferenceScript
      TxIn
      (Maybe ScriptHash)

It seems that, despite the comment, the script hash is nowhere used; I cloned the repo and removed it, adjusted the pattern match in scriptWitnessScript, and everything else just compiled.

The question is, can we remove the field? I'd gladly prepare the PR if we can.

Thanks!

Copy link

github-actions bot commented Sep 2, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Sep 2, 2024
@smelc smelc removed the Stale label Sep 2, 2024
@smelc
Copy link
Contributor

smelc commented Sep 2, 2024

cc @CarlosLopezDeLara

@Swordlash Swordlash linked a pull request Sep 23, 2024 that will close this issue
3 tasks
Copy link

github-actions bot commented Oct 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Oct 3, 2024
@smelc smelc removed the Stale label Oct 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 3, 2024
@Swordlash
Copy link
Contributor Author

Hi, any progress on this?

@carbolymer
Copy link
Contributor

@Swordlash we're working on it, the issue hasn't been forgotten.

@github-actions github-actions bot removed the Stale label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants