Fix tests

olivervogel · olivervogel · commit b028c2b76021 · 2025-01-05T12:18:12.000+01:00
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false" failOnWarning="true">
     <testsuites>
         <testsuite name="Package Test Suite">
             <directory suffix=".php">./tests/Unit/</directory>
diff --git a/src/Vaults/DigestVault.php b/src/Vaults/DigestVault.php
@@ -61,7 +61,7 @@ public function directive(): DirectiveInterface
      */
     private function tokenHash(TokenInterface $token): string
     {
-        $method = $_SERVER['REQUEST_METHOD'] ?: 'GET';
+        $method = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';
 
         return md5(implode(':', [
             md5(sprintf('%s:%s:%s', $token->username(), $this->realm(), $this->password())),

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function directive(): DirectiveInterface`
`61`	`61`	`*/`
`62`	`62`	`private function tokenHash(TokenInterface $token): string`
`63`	`63`	`{`
`64`		`- $method = $_SERVER['REQUEST_METHOD'] ?: 'GET';`
	`64`	`+ $method = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';`
`65`	`65`
`66`	`66`	`return md5(implode(':', [`
`67`	`67`	`md5(sprintf('%s:%s:%s', $token->username(), $this->realm(), $this->password())),`