Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ITwinObject.PlainToOnlineAsync() adds object properties to cyclic R/W #262

Closed
kuh0005 opened this issue Nov 21, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Milestone

Comments

@kuh0005
Copy link
Collaborator

kuh0005 commented Nov 21, 2023

Describe the bug

When calling the PlainToOnlineAsync() method, values are set over the nested primitive values into the Cyclic variable. Subsequently, the entire object is written to the controller using await this.WriteAsync(). In the implementation of the Cyclic method, periodicWriteSet() is also added, which causes that after the first upload to the controller, the write is duplicated by a periodic write as well.

 public virtual T Cyclic
 { ...
     set
     {
         if (HasWriteAccess())
         {
             CyclicToWrite = value;
             _cyclic = value;
             base.Parent.GetConnector()?.AddToPeriodicWriteSet(this);
         }
     }
 }
@kuh0005 kuh0005 added bug Something isn't working documentation Improvements or additions to documentation question Further information is requested labels Nov 21, 2023
@kuh0005 kuh0005 assigned kuh0005 and PTKu and unassigned kuh0005 Nov 21, 2023
@PTKu PTKu transferred this issue from Inxton/AXOpen Nov 22, 2023
@PTKu
Copy link
Contributor

PTKu commented Nov 22, 2023

already addressed in #261
@kuh0005 AXOpen (on Inxton/AXOpen#257) should be updated, test it and let me know.

@PTKu PTKu modified the milestones: v0.17, v0.18 Nov 22, 2023
@PTKu PTKu closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants