Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings should be editable #8

Open
2 tasks done
truedat101 opened this issue Jan 30, 2019 · 3 comments
Open
2 tasks done

settings should be editable #8

truedat101 opened this issue Jan 30, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request Needs Review
Milestone

Comments

@truedat101
Copy link
Contributor

truedat101 commented Jan 30, 2019

I thought the original plan was to make the settings editable. Edits would write a new gyr_values.yaml file. Task:

  • make reader duty cycle editable
  • make linger threshold editable
@truedat101 truedat101 added this to the Milestone 1.0 milestone Apr 4, 2019
@truedat101 truedat101 added the enhancement New feature or request label Apr 4, 2019
@davicitoafc
Copy link
Contributor

Can you explain what it means to be editable? You can go to the gyruss_values.yml and change the values.

@truedat101
Copy link
Contributor Author

That's not the point DC. The average user won't be logging into a server with SSH. The idea is that this is all easily configurable by a non-technical person or someone without a shell to login to the user. The original spec for the settings page was to have values that could be edited, i.e. web form that lets you view and edit the vales.

Edits would spit out a new gyruss_values.yml. If it is possible to put in input validation, that would be a plus.

@truedat101
Copy link
Contributor Author

I'll verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs Review
Projects
None yet
Development

No branches or pull requests

2 participants