Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the filename the link; remove "Download" #7

Open
dgingold opened this issue Nov 12, 2023 · 2 comments
Open

Make the filename the link; remove "Download" #7

dgingold opened this issue Nov 12, 2023 · 2 comments

Comments

@dgingold
Copy link

I like the way you provide the file path as the download link. The core links module has a folder mode, but the link it generates is ?FileId= instead of "/portals//folders.../filename" like yours. with yours, if the file is identified by the browser, it will display it. perfect for showing a folder full of PDFs. Each will display instead of download.
but row upon row of " Download" seems redundant; "Filename" looks better.
While you're under the hood, making it work for folder providers, (which is the case with my current client), maybe you'd consider this change as well? (You could remove the header too. In fact, making it a ul would be the best. I can style it as needed)

@mitchelsellers
Copy link
Contributor

@dgingold Right now this is designed for only NON-Secure folders thus not supporting folder providers. I could easily update it to support folder providers as desired.

We have also thought about implementing "Templates" in a loose manner for a "table", "List" or similar display.

The balance point is that there is not much functionality here. Thoughts?

@dgingold
Copy link
Author

Re: "Right now..." yes, saw the request to make it support folder providers, so i thought "while you're under the hood..."

Re: "Templates" sure, but not if it causes rethinking and puts off updating. I'd keep it as-is if it means a quicker update. just changing the output from the table with the "File" header to a simple

    would be great.

    Re: "not much functionality" - gov's love their PDFs. I have a few county clerks with GBs of them. They need a simple interface to upload them and then display them to the public.

    BTW, any thoughts on Azure provider and why it's painfully slow at uploading files? I wait maybe a minute for the smallest files to upload via Resource Manager, ckeditor, or a PlantAnApp file upload action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants