Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natural_coordinates_to_joint_angle should be renamed #83

Open
Ipuch opened this issue Aug 30, 2023 · 0 comments
Open

natural_coordinates_to_joint_angle should be renamed #83

Ipuch opened this issue Aug 30, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Ipuch
Copy link
Owner

Ipuch commented Aug 30, 2023

natural_coordinates_to_joint_angle method should be renamed

def natural_coordinates_to_joint_angles(self, Q: NaturalCoordinates):

And proper methods should be renamed to

model.natural_coordinates_to_minimal_coordinates(Q)

or

model.natural_coordinates_to_relative_coordinates(Q) 

It should be tested by the way.

@Ipuch Ipuch added the good first issue Good for newcomers label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant