chore: remove nx + remove bash scripts + convert to ESM where possible (#66)

* feat: todo

* feat: todo

* feat: todo

* feat: doto

* chore: fix build partially

* feat: everything except for docs working

* fix: all packages building + linting

* feat: new CI

* chore: revert docusaurus dep

* chore: test ci

* chore: test ci

* chore: test ci

* chore: test ci

* chore: test ci

* chore: fix ci

* chore: test ci

* fix: ci

* fix: ci

* fix: ci

* chore: fix ci

* fix: tests

* chore: try ci

* chore: test ci

* chore: test ci

* chore: fix ci

* fix: ci

Author: Zamiell

.eslintrc.cjs

@@ -5,7 +5,6 @@ const ESLINT_CONFIG_ISAACSCRIPT_PATH = path.join(
   REPO_ROOT,
   "packages",
   "eslint-config-isaacscript",
-  "configs",
 );
 
 /** @type {import("eslint").Linter.Config} */

.github/workflows/ci.yml

@@ -3,52 +3,105 @@ name: CI
 on: [push, pull_request]
 
 jobs:
-  build_and_lint:
+  get-build-packages:
     runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.set-matrix.outputs.matrix }}
     steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - id: set-matrix
+        run: npx tsx ./scripts/getMonorepoPackageNames.ts build
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: lts/*
-          cache: yarn
+  build:
+    needs: get-build-packages
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        package-name: ${{ fromJson(needs.get-build-packages.outputs.matrix) }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - working-directory: ./packages/${{ matrix.package-name }}
+        run: npm run build
 
-      - name: Retrieve the cached "node_modules" directory (if present)
-        uses: actions/cache@v3
-        id: node-cache
-        with:
-          path: node_modules
-          key: node-modules-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+  get-lint-packages:
+    runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.set-matrix.outputs.matrix }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - id: set-matrix
+        run: npx tsx ./scripts/getMonorepoPackageNames.ts lint
 
-      - name: Install dependencies (if the cached directory was not found)
-        if: steps.node-cache.outputs.cache-hit != 'true'
-        run: yarn install --immutable
+  lint:
+    needs: get-lint-packages
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        package-name: ${{ fromJson(needs.get-lint-packages.outputs.matrix) }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - working-directory: ./packages/${{ matrix.package-name }}
+        run: npm run lint
 
-      - name: Build every package in the monorepo
-        run: bash build.sh
+  get-test-packages:
+    runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.set-matrix.outputs.matrix }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - id: set-matrix
+        run: npx tsx ./scripts/getMonorepoPackageNames.ts test
 
-      - name: Test every package in the monorepo
-        run: bash test.sh
+  test:
+    needs: get-test-packages
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        package-name: ${{ fromJson(needs.get-test-packages.outputs.matrix) }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - working-directory: ./packages/${{ matrix.package-name }}
+        run: npm run test
 
-      - name: Lint every package in the monorepo
-        run: bash lint.sh
+  unused:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      #- name: Check for unused files, dependencies, and exports
+      #  run: npx knip
 
-      - name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
-        with:
-          ignore_paths: node_modules
+  format:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - run: npx prettier --log-level=warn --check .
 
-      # Uncomment this for SSH debugging of CI actions.
-      #- name: Setup tmate session
-      #  uses: mxschmitt/action-tmate@v3
-      #  with:
-      #    limit-access-to-actor: true
+  spell-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
+      - run: npx cspell --no-progress --no-summary .
+      - run: npx cspell-check-unused-words
+
+  docs-deploy:
+    needs: [build, lint, test, unused, format, spell-check]
+    runs-on: ubuntu-latest
+    if: github.ref == 'refs/heads/main' && needs.pr-check.outputs.number != 'null'
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/workflows/setup
 
       - name: Checkout the docs repository
         uses: actions/checkout@v3
-        if: github.ref == 'refs/heads/main' && needs.pr-check.outputs.number != 'null'
         with:
           ssh-key: ${{ secrets.DOCS_SSH_PRIVATE_KEY }}
           repository: IsaacScript/isaacscript.github.io
@@ -63,11 +116,10 @@ jobs:
       - name: Deploy the documentation website
         id: deploy_documentation_website
         run: bash packages/docs/deploy.sh ${{ github.sha }}
-        if: github.ref == 'refs/heads/main' && needs.pr-check.outputs.number != 'null'
 
       - name: Run DocSearch Scraper
         uses: celsiusnarhwal/typesense-scraper@v2
-        if: github.ref == 'refs/heads/main' && needs.pr-check.outputs.number != 'null' && steps.deploy_documentation_website.outputs.SHOULD_SCRAPE == '1'
+        if: steps.deploy_documentation_website.outputs.SHOULD_SCRAPE == '1'
         with:
           api-key: ${{ secrets.TYPESENSE_API_KEY }}
           host: ${{ secrets.TYPESENSE_HOST }}
@@ -77,7 +129,7 @@ jobs:
 
   discord:
     name: Discord Failure Notification
-    needs: [build_and_lint]
+    needs: [build, lint, test, unused, format, spell-check, docs-deploy]
     if: always() # This is needed to always run this job, even if the other jobs fail.
     runs-on: ubuntu-latest
     steps:

.github/workflows/setup/action.yml

@@ -0,0 +1,21 @@
+runs:
+  using: composite
+
+  steps:
+    - name: Setup Node.js
+      uses: actions/setup-node@v3
+      with:
+        node-version: lts/*
+        cache: yarn
+
+    - name: Retrieve the cached "node_modules" directory (if present)
+      uses: actions/cache@v3
+      id: node-modules-cache
+      with:
+        path: node_modules
+        key: client-build-node-modules-${{ hashFiles('yarn.lock') }}
+
+    - name: Install dependencies (if the cached directory was not found)
+      if: steps.node-modules-cache.outputs.cache-hit != 'true'
+      run: yarn install --immutable
+      shell: bash # Composite jobs must specify the shell.

.gitignore

@@ -2,25 +2,28 @@
 # isaacscript
 # -----------
 
-# NX artifacts
-tmp
-
-# Docusaurus artifacts
-.cache-loader
-
 # OS-specific artifacts
 .DS_Store
 thumbs.db
 
+# Docusaurus artifacts
+build
+.docusaurus
+.cache-loader
+
 # Ignore the auto-generated API docs from TypeDoc (since it will just contain duplicate information
 # from what is already in the JSDoc comments of the source code).
+packages/docs/docs/eslint-config-isaacscript
 packages/docs/docs/isaacscript-common
 packages/docs/docs/isaac-typescript-definitions
-packages/docs/docs/eslint-config-isaacscript
+
+# Temporary build files
+packages/isaacscript-common/src/indexLua.ts
 
 # ------------------------------
 # GitHub Node.gitignore template
 # https://raw.githubusercontent.com/github/gitignore/master/Node.gitignore
+# cspell:disable
 # ------------------------------
 
 # Logs

.markdownlintignore

@@ -1,7 +1,7 @@
 .gitignore
 .markdownlintignore
-.remarkignore
 node_modules
 dist
+packages/docs/docs/eslint-config-isaacscript
 packages/docs/docs/isaacscript-common
 packages/docs/docs/isaac-typescript-definitions

.prettierignore

@@ -22,17 +22,13 @@ mod/resources/**/*.anm2
 
 # @template-customization-start
 
-# NX temporary directory
-tmp
+# Compiled plugins
+packages/isaacscript-cli/plugins/*.cjs
 
 # Docusaurus artifacts
 .docusaurus
 .cache-loader
 
-# "prettier-plugin-organize-imports" is bugged with JSX.
-packages/docs/src/components/HomepageFeatures.js
-packages/docs/src/pages/index.js
-
 # API docs are automatically created by TypeDoc.
 packages/docs/docs/isaacscript-common
 packages/docs/docs/isaac-typescript-definitions

.remarkignore

@@ -4,7 +4,8 @@
   // Vanilla settings
   // ----------------
 
-  // This matches the Airbnb JavaScript style guide.
+  // This matches the Airbnb JavaScript style guide, which is the most popular JavaScript style
+  // guide in the world.
   "editor.rulers": [100],
   "editor.tabSize": 2,
 
@@ -43,7 +44,7 @@
   // Extension settings
   // ------------------
 
-  // Use Prettier to format "cspell.json".
+  // Use Prettier to format "cspell.jsonc".
   "cSpell.autoFormatConfigFile": true,
 
   // -----------------

.vscode/settings.json

@@ -10,7 +10,7 @@ IsaacScript is a tool to help you create [_Binding of Isaac: Repentance_](https:
 
 Please visit the [official website](https://isaacscript.github.io/) for more information.
 
-This is the [monorepo](https://en.wikipedia.org/wiki/Monorepo) that houses the various packages in the ecosystem. It is powered by [Nx](https://nx.dev/).
+This is the [monorepo](https://en.wikipedia.org/wiki/Monorepo) that houses the various packages in the ecosystem.
 
 <br>
 
@@ -26,8 +26,9 @@ Each project in the monorepo is contained within the "packages" directory.
 | [isaac-lua-polyfill](./packages/isaac-lua-polyfill)                     | Polyfills for testing Isaac mods using TypeScript.                         | [![npm version](https://img.shields.io/npm/v/isaac-lua-polyfill.svg)](https://www.npmjs.com/package/isaac-lua-polyfill)                     |
 | [isaac-typescript-definitions](./packages/isaac-typescript-definitions) | TypeScript definitions for the _The Binding of Isaac: Repentance_ API.     | [![npm version](https://img.shields.io/npm/v/isaac-typescript-definitions.svg)](https://www.npmjs.com/package/isaac-typescript-definitions) |
 | [isaacscript-cli](./packages/isaacscript-cli)                           | The command-line tool for managing Isaac mods written in TypeScript.       | [![npm version](https://img.shields.io/npm/v/isaacscript.svg)](https://www.npmjs.com/package/isaacscript)                                   |
-| [isaacscript-common-ts](./packages/isaacscript-common-ts)               | Helper functions for TypeScript projects.                                  | [![npm version](https://img.shields.io/npm/v/isaacscript-common-ts.svg)](https://www.npmjs.com/package/isaacscript-common-ts)               |
 | [isaacscript-common](./packages/isaacscript-common)                     | Helper functions and features for IsaacScript mods.                        | [![npm version](https://img.shields.io/npm/v/isaacscript-common.svg)](https://www.npmjs.com/package/isaacscript-common)                     |
+| [isaacscript-common-node](./packages/isaacscript-common-node)           | Helper functions for Node.js projects.                                     | [![npm version](https://img.shields.io/npm/v/isaacscript-common-node.svg)](https://www.npmjs.com/package/isaacscript-common-node)           |
+| [isaacscript-common-ts](./packages/isaacscript-common-ts)               | Helper functions for TypeScript projects.                                  | [![npm version](https://img.shields.io/npm/v/isaacscript-common-ts.svg)](https://www.npmjs.com/package/isaacscript-common-ts)               |
 | [isaacscript-lint](./packages/isaacscript-lint)                         | A linting dependency meta-package for IsaacScript and TypeScript projects. | [![npm version](https://img.shields.io/npm/v/isaacscript-lint.svg)](https://www.npmjs.com/package/isaacscript-lint)                         |
 | [isaacscript-lua](./packages/isaacscript-lua)                           | A tool for managing IsaacScript libraries in Lua projects.                 | [![pypi version](https://img.shields.io/pypi/v/isaacscript-lua.svg)](https://pypi.org/project/isaacscript-lua/)                             |
 | [isaacscript-spell](./packages/isaacscript-spell)                       | Spelling dictionaries for _The Binding of Isaac: Repentance_.              | [![npm version](https://img.shields.io/npm/v/isaacscript-spell.svg)](https://www.npmjs.com/package/isaacscript-spell)                       |

README.md

@@ -0,0 +1,34 @@
+#!/bin/bash
+
+set -euo pipefail # Exit on errors and undefined variables.
+
+# Get the directory of this script:
+# https://stackoverflow.com/questions/59895/getting-the-source-directory-of-a-bash-script-from-within
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+
+cd "$DIR"
+
+WINDOWS_FILES=$(
+  grep \
+  --recursive \
+  --files-with-matches \
+  --binary \
+  --perl-regexp \
+  --exclude-dir='.git' \
+  --exclude-dir='.yarn' \
+  --exclude-dir='node_modules' \
+  --exclude='*.fnt' \
+  --exclude='*.jpg' \
+  --exclude='*.png' \
+  --exclude='*.pyc' \
+  --exclude='*.stb' \
+  --exclude='*.ttf' \
+  --exclude='*.wav' \
+  --exclude='yarn.lock' \
+  '\r$' .
+) || true
+if [[ $WINDOWS_FILES ]]; then
+  echo "Files with Windows line-endings were found:"
+  echo "$WINDOWS_FILES"
+  exit 1
+fi