fix: lint

Author: Zamiell

packages/isaacscript-common-node/src/functions/packageJSON.ts

@@ -36,8 +36,8 @@ export function getPackageJSON(
 }
 
 /**
- * Helper function to get the "dependencies" or "devDependencies" field from a "package.json" file.
- * If the corresponding field does not exist, `undefined` will be returned.
+ * Helper function to get the "dependencies" or "devDependencies" or "peerDependencies" field from a
+ * "package.json" file. If the corresponding field does not exist, `undefined` will be returned.
  *
  * This will print an error message and exit the program if the "package.json" file cannot be found
  * or is otherwise invalid.
@@ -52,7 +52,7 @@ export function getPackageJSON(
 export function getPackageJSONDependencies(
   filePathOrDirPathOrRecord: string | Record<string, unknown> | undefined,
   dependencyFieldName: PackageJSONDependencyFieldName = "dependencies",
-): Record<string, unknown> | undefined {
+): Record<string, string> | undefined {
   const packageJSON =
     typeof filePathOrDirPathOrRecord === "object"
       ? filePathOrDirPathOrRecord
@@ -81,7 +81,19 @@ export function getPackageJSONDependencies(
     );
   }
 
-  return field;
+  for (const [key, value] of Object.entries(field)) {
+    if (typeof value !== "string") {
+      fatalError(
+        `Failed to parse the "${chalk.green(
+          dependencyFieldName,
+        )}" field in a "${chalk.green(
+          PACKAGE_JSON,
+        )}" file since the "${chalk.green(key)}" entry was not a string.`,
+      );
+    }
+  }
+
+  return field as Record<string, string>;
 }
 
 /**

scripts/packageJSONLint.ts

@@ -8,6 +8,7 @@ import {
   echo,
   exit,
   getPackageJSON,
+  getPackageJSONDependencies,
   readFile,
 } from "isaacscript-common-node";
 import { isKebabCase } from "isaacscript-common-ts";
@@ -229,12 +230,6 @@ function packageJSONLint(
     }
   }
 
-  const { files } = packageJSON;
-  if (files !== undefined) {
-    echo(`File has a "files" field: ${packageJSONPath}`);
-    return false;
-  }
-
   if (!isTemplateFile && rootDeps !== undefined) {
     const { dependencies } = packageJSON;
     if (!checkDeps(dependencies, rootDeps, packageJSONPath)) {
@@ -255,24 +250,17 @@ function packageJSONLint(
 
 /** Gets the dependencies of the root monorepo "package.json" file. */
 function getDeps(packageJSONPath: string): Record<string, string> {
-  const packageJSONString = readFile(packageJSONPath);
-  const packageJSON = getPackageJSON(packageJSONString);
-
-  let { dependencies, devDependencies, peerDependencies } = packageJSON;
-  if (typeof dependencies !== "object") {
-    dependencies = {};
-  }
-  if (typeof devDependencies !== "object") {
-    devDependencies = {};
-  }
-  if (typeof peerDependencies !== "object") {
-    peerDependencies = {};
-  }
+  const dependencies =
+    getPackageJSONDependencies(packageJSONPath, "dependencies") ?? {};
+  const devDependencies =
+    getPackageJSONDependencies(packageJSONPath, "devDependencies") ?? {};
+  const peerDependencies =
+    getPackageJSONDependencies(packageJSONPath, "peerDependencies") ?? {};
 
   const deps = {
-    ...(dependencies as Record<string, string>),
-    ...(devDependencies as Record<string, string>),
-    ...(peerDependencies as Record<string, string>),
+    ...dependencies,
+    ...devDependencies,
+    ...peerDependencies,
   };
 
   // `eslint-plugin-isaacscript` is not a root dependency of the monorepo, so it has to be
@@ -292,8 +280,7 @@ function getVersionForSpecificPackage(packageName: string): string {
     packageName,
     "package.json",
   );
-  const packageJSONString = readFile(packageJSONPath);
-  const packageJSON = getPackageJSON(packageJSONString);
+  const packageJSON = getPackageJSON(packageJSONPath);
   const packageVersion = packageJSON["version"];
   if (typeof packageVersion !== "string") {
     throw new TypeError(`Failed to parse the version from: ${packageJSONPath}`);
@@ -325,8 +312,7 @@ function checkDeps(
         key,
         PACKAGE_JSON,
       );
-      const depPackageJSONString = readFile(depPackageJSONPath);
-      const depPackageJSON = getPackageJSON(depPackageJSONString);
+      const depPackageJSON = getPackageJSON(depPackageJSONPath);
       const depVersion = depPackageJSON["version"];
       if (typeof depVersion !== "string") {
         throw new TypeError(
@@ -360,8 +346,7 @@ function checkRootDepsUpToDate(
       continue;
     }
 
-    const packageJSONString = readFile(matchingPackageJSONPath);
-    const packageJSON = getPackageJSON(packageJSONString);
+    const packageJSON = getPackageJSON(matchingPackageJSONPath);
 
     const { version } = packageJSON;
     if (typeof version !== "string" || version === "") {