From ad246bfa07aab642a38aeafdbfd0a0687c7a2781 Mon Sep 17 00:00:00 2001 From: Ismael Martinez Ramos Date: Fri, 23 Aug 2024 16:08:41 +0100 Subject: [PATCH] fix the code scanning security advisory 2 and adding more info on the render-process-gone --- app/index.js | 5 +++-- app/mainAppWindow/index.js | 2 +- com.github.IsmaelMartinez.teams_for_linux.appdata.xml | 8 ++++++++ package.json | 2 +- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/app/index.js b/app/index.js index a65f9bb4..98dd9dfc 100644 --- a/app/index.js +++ b/app/index.js @@ -203,8 +203,9 @@ async function playNotificationSound(_event, options) { console.debug('No notification sound played', player, options); } -function onRenderProcessGone() { - console.debug('render-process-gone'); +function onRenderProcessGone(event, details) { + console.error(`render-process-gone with reason: '${details.reason}'.`); + console.error(`Event '${event}' and details '${details}'`); app.quit(); } diff --git a/app/mainAppWindow/index.js b/app/mainAppWindow/index.js index b9a68922..ca5f9345 100644 --- a/app/mainAppWindow/index.js +++ b/app/mainAppWindow/index.js @@ -200,7 +200,7 @@ function restoreWindow() { function processArgs(args) { const v1msTeams = /^msteams:\/l\/(?:meetup-join|channel)/g; - const v2msTeams = /^msteams:\/\/teams.microsoft.com\/l\/(?:meetup-join|channel)/g; + const v2msTeams = /^msteams:\/\/teams\.microsoft\.com\/l\/(?:meetup-join|channel)/g; console.debug('processArgs:', args); for (const arg of args) { console.debug(`testing RegExp processArgs ${new RegExp(config.meetupJoinRegEx).test(arg)}`); diff --git a/com.github.IsmaelMartinez.teams_for_linux.appdata.xml b/com.github.IsmaelMartinez.teams_for_linux.appdata.xml index ceb6bd54..38a5d9b4 100644 --- a/com.github.IsmaelMartinez.teams_for_linux.appdata.xml +++ b/com.github.IsmaelMartinez.teams_for_linux.appdata.xml @@ -14,6 +14,14 @@ https://github.com/IsmaelMartinez/teams-for-linux/issues com.github.IsmaelMartinez.teams_for_linux.desktop + + +
    +
  • Fix Incomplete regular expression for hostnames for github scanning in ms teams url
  • +
  • Printing the render-process-gone reason to help analyse #1369
  • +
+
+
    diff --git a/package.json b/package.json index ef01d35e..3635ea3e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "teams-for-linux", - "version": "1.9.4", + "version": "1.9.5", "main": "app/index.js", "description": "Unofficial client for Microsoft Teams for Linux", "homepage": "https://github.com/IsmaelMartinez/teams-for-linux",