Skip to content

Commit ecf46fe

Browse files
committed
🗑️ Removed Iterable specific identifiers and hardcoded URLs to use generic ones instead on the sample app.
1 parent 89a68e9 commit ecf46fe

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ - (BOOL)handleIterableURL:(NSURL *)url context:(IterableActionContext *)context
134134
- (BOOL)handleIterableCustomAction:(IterableAction *)action context:(IterableActionContext *)context {
135135
if ([action.type isEqualToString:@"handleFindCoffee"]) {
136136
if (action.userInput != nil) {
137-
NSString *urlString = [[NSString alloc] initWithFormat:@"https://majumder.me/coffee?q=%@", action.userInput];
137+
NSString *urlString = [[NSString alloc] initWithFormat:@"https://example.com/coffee?q=%@", action.userInput];
138138
NSURL *url = [[NSURL alloc] initWithString:urlString];
139139
return [DeepLinkHandler handleURL:url];
140140
}

sample-apps/objc-sample-app/objc-sample-app/objc-sample-app.entitlements

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
<string>development</string>
77
<key>com.apple.developer.associated-domains</key>
88
<array>
9-
<string>applinks:majumder.me</string>
10-
<string>applinks:links.majumder.me</string>
9+
<string>applinks:example.com</string>
10+
<string>applinks:links.example.com</string>
1111
</array>
1212
</dict>
1313
</plist>

sample-apps/swift-sample-app/swift-sample-app.xcodeproj/project.pbxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -489,13 +489,13 @@
489489
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
490490
CODE_SIGN_ENTITLEMENTS = "swift-sample-app/swift-sample-app.entitlements";
491491
CODE_SIGN_STYLE = Automatic;
492-
DEVELOPMENT_TEAM = BP98Z28R86;
492+
DEVELOPMENT_TEAM = "";
493493
INFOPLIST_FILE = "swift-sample-app/Info.plist";
494494
LD_RUNPATH_SEARCH_PATHS = (
495495
"$(inherited)",
496496
"@executable_path/Frameworks",
497497
);
498-
PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app";
498+
PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app";
499499
PRODUCT_NAME = "$(TARGET_NAME)";
500500
SWIFT_VERSION = 5.0;
501501
TARGETED_DEVICE_FAMILY = "1,2";
@@ -508,13 +508,13 @@
508508
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
509509
CODE_SIGN_ENTITLEMENTS = "swift-sample-app/swift-sample-app.entitlements";
510510
CODE_SIGN_STYLE = Automatic;
511-
DEVELOPMENT_TEAM = BP98Z28R86;
511+
DEVELOPMENT_TEAM = "";
512512
INFOPLIST_FILE = "swift-sample-app/Info.plist";
513513
LD_RUNPATH_SEARCH_PATHS = (
514514
"$(inherited)",
515515
"@executable_path/Frameworks",
516516
);
517-
PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app";
517+
PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app";
518518
PRODUCT_NAME = "$(TARGET_NAME)";
519519
SWIFT_VERSION = 5.0;
520520
TARGETED_DEVICE_FAMILY = "1,2";
@@ -525,14 +525,14 @@
525525
isa = XCBuildConfiguration;
526526
buildSettings = {
527527
CODE_SIGN_STYLE = Automatic;
528-
DEVELOPMENT_TEAM = BP98Z28R86;
528+
DEVELOPMENT_TEAM = "";
529529
INFOPLIST_FILE = "swift-sample-app-notification-extension/Info.plist";
530530
LD_RUNPATH_SEARCH_PATHS = (
531531
"$(inherited)",
532532
"@executable_path/Frameworks",
533533
"@executable_path/../../Frameworks",
534534
);
535-
PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app.swift-sample-app-notification-extension";
535+
PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app.swift-sample-app-notification-extension";
536536
PRODUCT_NAME = "$(TARGET_NAME)";
537537
SKIP_INSTALL = YES;
538538
SWIFT_VERSION = 5.0;
@@ -544,14 +544,14 @@
544544
isa = XCBuildConfiguration;
545545
buildSettings = {
546546
CODE_SIGN_STYLE = Automatic;
547-
DEVELOPMENT_TEAM = BP98Z28R86;
547+
DEVELOPMENT_TEAM = "";
548548
INFOPLIST_FILE = "swift-sample-app-notification-extension/Info.plist";
549549
LD_RUNPATH_SEARCH_PATHS = (
550550
"$(inherited)",
551551
"@executable_path/Frameworks",
552552
"@executable_path/../../Frameworks",
553553
);
554-
PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app.swift-sample-app-notification-extension";
554+
PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app.swift-sample-app-notification-extension";
555555
PRODUCT_NAME = "$(TARGET_NAME)";
556556
SKIP_INSTALL = YES;
557557
SWIFT_VERSION = 5.0;

sample-apps/swift-sample-app/swift-sample-app/AppDelegate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ extension AppDelegate: IterableCustomActionDelegate {
165165
func handle(iterableCustomAction action: IterableAction, inContext _: IterableActionContext) -> Bool {
166166
if action.type == "handleFindCoffee" {
167167
if let query = action.userInput {
168-
return DeepLinkHandler.handle(url: URL(string: "https://majumder.me/coffee?q=\(query)")!)
168+
return DeepLinkHandler.handle(url: URL(string: "https://example.com/coffee?q=\(query)")!)
169169
}
170170
}
171171
return false

sample-apps/swift-sample-app/swift-sample-app/swift-sample-app.entitlements

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
<string>development</string>
77
<key>com.apple.developer.associated-domains</key>
88
<array>
9-
<string>applinks:majumder.me</string>
10-
<string>applinks:links.majumder.me</string>
9+
<string>applinks:example.com</string>
10+
<string>applinks:links.example.com</string>
1111
</array>
1212
</dict>
1313
</plist>

0 commit comments

Comments
 (0)