Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compensation Public UI small issues #1364

Open
2 of 4 tasks
damienen opened this issue May 7, 2024 · 1 comment
Open
2 of 4 tasks

Compensation Public UI small issues #1364

damienen opened this issue May 7, 2024 · 1 comment
Assignees
@damienen @Enciusan

Comments

@damienen
Copy link
Member

damienen commented May 7, 2024 •
edited
Loading

  • Needs a loading animation until compensations are fetched
  • Calls to the API need to be made more efficient (in CompensationCards, the dataNftsInScT object contructs the NFTs before knowing if it needs them or not. It should first check what NFTs it needs and then construct them)
  • If an address is blacklisted from said compensation and they deposit their NFT as proof, they are shown like they will receive compensation, but they actually only receive their NFT back. This should be reflected in the UI
  • If an address is blacklisted, on UI level the compensation amount is wrongly calculted
@damienen damienen changed the title Compensation Public UI needs a loading animation until compensations are fetched Compensation Public UI small issues May 9, 2024
Enciusan added a commit that referenced this issue May 14, 2024
@Enciusan
fix: compensation ui
b786852 
issue: #1364
@damienen damienen self-assigned this May 23, 2024
@damienen
Copy link
Member Author

Good enough implementation for now. The other we will defer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienen damienen

@Enciusan Enciusan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damienen @Enciusan