Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensorCentralFrequency data type should be a float #1370

Open
rhoneyager-tomorrow opened this issue Sep 18, 2023 · 0 comments
Open

sensorCentralFrequency data type should be a float #1370

rhoneyager-tomorrow opened this issue Sep 18, 2023 · 0 comments
Labels
bug Something is not working OBS OBS processing, UFO

Comments

@rhoneyager-tomorrow
Copy link
Contributor

rhoneyager-tomorrow commented Sep 18, 2023

This is mostly a documentation issue since I'm unsure if any IODA converter writes out the sensorCentralFrequency and radarPulseFrequency variables, but under the current version of IODA they can't be double precision variables. This is because IODA's VarUtils functions lack support for double-precision floating point numbers. This prevents a double-containing IODA file from being read into an ObsSpace.

Fixes:

Option A: Change the docs and make sensorCentralFrequency a plain old float.

  1. https://github.com/JCSDA/ioda/blob/develop/share/ioda/yaml/validation/ObsSpace.yaml#L952 -> Double to Float.
  2. Obs variable names table

Option B: IODA type system refactor. This would be much harder, though in JCSDA-internal/ioda I left branches from my attempt about two years ago.

@rhoneyager-tomorrow rhoneyager-tomorrow added the bug Something is not working label Sep 18, 2023
@BenjaminRuston BenjaminRuston added the OBS OBS processing, UFO label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working OBS OBS processing, UFO
Projects
None yet
Development

No branches or pull requests

2 participants