-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
treetap/src/main/resources/data/treetap/recipe/water_from_crying_obsidian.json
Lines 11 to 13 in 17ae9a3
| "display_fluid": { | |
| "fluid": "minecraft:water" | |
| } |
Is missing an amount field since display_fluid is serialized as a FluidStack:
treetap/src/main/java/cy/jdkdigital/treetap/common/block/recipe/TapExtractRecipe.java
Line 93 in 17ae9a3
| FluidStack.CODEC.fieldOf("display_fluid").orElse(new FluidStack(Fluids.WATER, 1000)).forGetter(recipe -> recipe.displayFluid), |
Since amount in FluidStack is now required:
public static final Codec<FluidStack> CODEC = Codec.lazyInitialized(
() -> RecordCodecBuilder.create(
instance -> instance.group(
FLUID_NON_EMPTY_CODEC.fieldOf("id").forGetter(FluidStack::getFluidHolder),
ExtraCodecs.POSITIVE_INT.fieldOf("amount").forGetter(FluidStack::getAmount), // note: no .orElse(1) compared to ItemStack
DataComponentPatch.CODEC.optionalFieldOf("components", DataComponentPatch.EMPTY)
.forGetter(stack -> stack.components.asPatch()))
.apply(instance, FluidStack::new)));This will cause deserialization error when adding recipe support for KubeJS:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
