Skip to content

Commit 097c700

Browse files
committed
Improve the data tracing structure
Adding dataset index and also fix bugs in PCe approaches
1 parent 288fc28 commit 097c700

14 files changed

+232
-271
lines changed

R/xfaostat_L102_ProductionArea.R

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ module_xfaostat_L102_ProductionArea <- function(command, ...) {
2323
"FBSH_CBH_wide")
2424

2525
MODULE_OUTPUTS <-
26-
c("QCL_PROD",
27-
"QCL_AN_LIVEANIMAL",
28-
"QCL_AN_PRIMARY_MILK",
29-
"QCL_AN_LIVEANIMAL_MEATEQ",
30-
"QCL_CROP_PRIMARY")
26+
c("L102.QCL_PROD",
27+
"L102.QCL_AN_LIVEANIMAL",
28+
"L102.QCL_AN_PRIMARY_MILK",
29+
"L102.QCL_AN_LIVEANIMAL_MEATEQ",
30+
"L102.QCL_CROP_PRIMARY")
3131

3232
if(command == driver.DECLARE_INPUTS) {
3333
return(MODULE_INPUTS)
@@ -378,7 +378,7 @@ module_xfaostat_L102_ProductionArea <- function(command, ...) {
378378

379379

380380

381-
# Bind QCL_ALL and save RDS ----
381+
# Bind L102.QCL_ALL and save RDS ----
382382
#*******************************************
383383

384384
QCL_CROP_PRIMARY %>% mutate(item_set = "QCL_COMM_CROP_PRIMARY") %>%
@@ -392,10 +392,10 @@ module_xfaostat_L102_ProductionArea <- function(command, ...) {
392392
bind_rows(QCL_AN_LIVEANIMAL %>% mutate(item_set = "QCL_COMM_AN_LIVEANIMAL")) %>%
393393
bind_rows(QCL_AN_LIVEANIMAL_MEATEQ %>% mutate(item_set = "QCL_COMM_AN_LIVEANIMAL_MEATEQ")) %>%
394394
bind_rows(FBS_FISH %>% mutate(item_set = "FBS_COMM_FISH"))->
395-
QCL_ALL
395+
L102.QCL_ALL
396396

397397

398-
QCL_ALL %>%
398+
L102.QCL_ALL %>%
399399
filter(item_set %in% c("QCL_COMM_AN_PRIMARY_MEAT1",
400400
"QCL_COMM_AN_PRIMARY_MEAT2",
401401
"QCL_COMM_AN_PRIMARY_EGG",
@@ -408,60 +408,60 @@ module_xfaostat_L102_ProductionArea <- function(command, ...) {
408408
add_units("various") %>%
409409
add_comments("Detailed FAO QCL data processing for live animal and production") %>%
410410
add_precursors("QCL_wide", "FBS_wide", "FBSH_CBH_wide") ->
411-
QCL_AN_LIVEANIMAL
411+
L102.QCL_AN_LIVEANIMAL
412412

413413
QCL_AN_PRIMARY_MILK %>%
414414
add_title("FAO milk animal stock and production") %>%
415415
add_units("various") %>%
416416
add_comments("Detailed FAO QCL data processing for dairy animal and production") %>%
417-
same_precursors_as(QCL_AN_LIVEANIMAL) ->
418-
QCL_AN_PRIMARY_MILK
417+
same_precursors_as(L102.QCL_AN_LIVEANIMAL) ->
418+
L102.QCL_AN_PRIMARY_MILK
419419

420420
QCL_AN_LIVEANIMAL_MEATEQ %>%
421421
add_title("FAO live animal stock meat equivalent") %>%
422422
add_units("various") %>%
423423
add_comments("Detailed FAO QCL data processing for live animal stock meat equivalent") %>%
424-
same_precursors_as(QCL_AN_LIVEANIMAL) ->
425-
QCL_AN_LIVEANIMAL_MEATEQ
424+
same_precursors_as(L102.QCL_AN_LIVEANIMAL) ->
425+
L102.QCL_AN_LIVEANIMAL_MEATEQ
426426

427427
QCL_CROP_PRIMARY %>%
428428
add_title("FAO primary crop area and production") %>%
429429
add_units("various") %>%
430430
add_comments("Detailed FAO QCL data processing for crop area and production") %>%
431-
same_precursors_as(QCL_AN_LIVEANIMAL) ->
432-
QCL_CROP_PRIMARY
431+
same_precursors_as(L102.QCL_AN_LIVEANIMAL) ->
432+
L102.QCL_CROP_PRIMARY
433433

434434

435435
# Production only
436-
QCL_ALL %>% filter(element_code == 5510) ->
437-
QCL_PROD
436+
L102.QCL_ALL %>% filter(element_code == 5510) ->
437+
L102.QCL_PROD
438438

439-
QCL_PROD %>%
439+
L102.QCL_PROD %>%
440440
add_title("FAO primary production") %>%
441441
add_units("tonnes") %>%
442442
add_comments("FAO primary production") %>%
443-
same_precursors_as(QCL_AN_LIVEANIMAL) ->
444-
QCL_PROD
443+
same_precursors_as(L102.QCL_AN_LIVEANIMAL) ->
444+
L102.QCL_PROD
445445

446446
# No NA
447-
assertthat::assert_that(QCL_ALL %>% filter(is.na(value)) %>% nrow() == 0)
447+
assertthat::assert_that(L102.QCL_ALL %>% filter(is.na(value)) %>% nrow() == 0)
448448

449-
#QCL_ALL %>% FF_check_count_plot -> p; p
449+
#L102.QCL_ALL %>% FF_check_count_plot -> p; p
450450
# ggsave(file.path(DIR_DATAPROC_PLOT, "QCL_ALL.png"),
451451
# plot = p + ggtitle("gcamdata-FAOSTAT (QCL & FBS) production data over time"),
452452
# dpi = 200, width = 9, height = 5 )
453453
# rm(p)
454454

455-
QCL_ALL %>% distinct(year); # 53 years
456-
QCL_ALL %>% distinct(element, element_code, unit) # QCL_COMM_AN_LIVEANIMAL_MEATEQ has no element_code
457-
QCL_ALL %>% distinct(item) # 158 primary crop + 45 primary an + 57 others + 17 +12
455+
L102.QCL_ALL %>% distinct(year); # 53 years
456+
L102.QCL_ALL %>% distinct(element, element_code, unit) # QCL_COMM_AN_LIVEANIMAL_MEATEQ has no element_code
457+
L102.QCL_ALL %>% distinct(item) # 158 primary crop + 45 primary an + 57 others + 17 +12
458458

459459

460-
# QCL_ALL %>%
460+
# L102.QCL_ALL %>%
461461
# add_title("FAO crop and livestock production and crop area") %>%
462462
# add_units("various") %>%
463463
# add_comments("Detailed FAO QCL data processing. FBS fish data is used") ->
464-
# QCL_ALL
464+
# L102.QCL_ALL
465465

466466

467467
return_data(MODULE_OUTPUTS)

R/xfaostat_L103_ProducerPrices.R

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
module_xfaostat_L103_ProducerPrices <- function(command, ...) {
1919

2020
MODULE_INPUTS <-
21-
c("QCL_PROD",
21+
c("L102.QCL_PROD",
2222
"PP_wide")
2323

2424
MODULE_OUTPUTS <-
25-
c("QCL_PRIMARY_PROD_PV")
25+
c("L103.QCL_PRIMARY_PROD_PV")
2626

2727
if(command == driver.DECLARE_INPUTS) {
2828
return(MODULE_INPUTS)
@@ -32,7 +32,7 @@ module_xfaostat_L103_ProducerPrices <- function(command, ...) {
3232

3333
year <- value <- Year <- Value <- FAO_country <- iso <- NULL # silence package check.
3434
PP_wide <- element_code <- element <- area_code <- item_code <- area <-
35-
item <- unit <- QCL_PROD <- item_set <- GCAM_commodity <- QCL_PRIMARY_item <-
35+
item <- unit <- L102.QCL_PROD <- item_set <- GCAM_commodity <- QCL_PRIMARY_item <-
3636
PP_item <- Production <- Prod_Value <- PP_index <- World_PP_index <-
3737
PP_Multiplier <- PP_item_world <- NULL
3838

@@ -50,15 +50,15 @@ module_xfaostat_L103_ProducerPrices <- function(command, ...) {
5050

5151

5252
# Primary crops
53-
QCL_PROD %>% filter(item_set == "QCL_COMM_CROP_PRIMARY") %>%
53+
L102.QCL_PROD %>% filter(item_set == "QCL_COMM_CROP_PRIMARY") %>%
5454
distinct(item, item_code) -> QCL_COMM_CROP_PRIMARY
5555
# Primary animal products, including fat hides etc. 46
56-
QCL_PROD %>% filter(grepl("AN_PRIMARY", item_set) ) %>%
56+
L102.QCL_PROD %>% filter(grepl("AN_PRIMARY", item_set) ) %>%
5757
distinct(item, item_code) -> QCL_COMM_AN_PRIMARY
5858

5959
QCL_COMM_CROP_PRIMARY %>%
6060
bind_rows(QCL_COMM_AN_PRIMARY) %>%
61-
left_join(QCL_PROD, by = c("item_code", "item")) ->
61+
left_join(L102.QCL_PROD, by = c("item_code", "item")) ->
6262
QCL_PRIMARY
6363

6464
QCL_PRIMARY %>% distinct(item, element, item_set, unit)
@@ -129,17 +129,17 @@ module_xfaostat_L103_ProducerPrices <- function(command, ...) {
129129
left_join(UnitMap %>%
130130
bind_rows(UnitMap %>% mutate(element = "Prod_Value", unit = "USD")),
131131
by = "element") ->
132-
QCL_PRIMARY_PROD_PV
132+
L103.QCL_PRIMARY_PROD_PV
133133

134134
rm(QV1, QV)
135135

136-
QCL_PRIMARY_PROD_PV %>%
136+
L103.QCL_PRIMARY_PROD_PV %>%
137137
add_title("FAO crop and livestock production and crop area") %>%
138138
add_units("USD and tonne") %>%
139139
add_comments("Detailed FAO QCL data processing. FBS fish data is used") %>%
140-
add_precursors("QCL_PROD",
140+
add_precursors("L102.QCL_PROD",
141141
"PP_wide") ->
142-
QCL_PRIMARY_PROD_PV
142+
L103.QCL_PRIMARY_PROD_PV
143143

144144
return_data(MODULE_OUTPUTS)
145145

R/xfaostat_L104_ProductionAreaAddFodder.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ module_xfaostat_L104_ProductionAreaAddFodder <- function(command, ...) {
2222
"QCL_area_code_map")
2323

2424
MODULE_OUTPUTS <-
25-
c("QCL_FODDERCROP")
25+
c("L104.QCL_FODDERCROP")
2626

2727
if(command == driver.DECLARE_INPUTS) {
2828
return(MODULE_INPUTS)
@@ -95,17 +95,17 @@ module_xfaostat_L104_ProductionAreaAddFodder <- function(command, ...) {
9595
# Remove area x year that should no exist
9696
FAOSTAT_AREA_RM_NONEXIST %>%
9797
left_join(UnitMap, by = "element") ->
98-
QCL_FODDERCROP
98+
L104.QCL_FODDERCROP
9999

100100
rm(FAO_fodder_Prod_t_HA_ha_PRODSTAT_2011, UnitMap)
101101

102-
QCL_FODDERCROP %>%
102+
L104.QCL_FODDERCROP %>%
103103
add_title("Processed fodder crop production and area") %>%
104104
add_units("tonne and ha") %>%
105105
add_comments("Data is from old GCAM data v5.4") %>%
106106
add_precursors(file.path(DIR_RAW_DATA_FAOSTAT, "Other_supplementary/FAO_fodder_Prod_t_HA_ha_PRODSTAT_2011"),
107107
"QCL_area_code_map")->
108-
QCL_FODDERCROP
108+
L104.QCL_FODDERCROP
109109

110110

111111
# FAO_ag_items_PRODSTAT is not read in anymore

0 commit comments

Comments
 (0)